public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v1 1/1] test_robind: add "-f" mkfs option for xfs and	btrfs
Date: Tue, 24 May 2016 10:01:12 -0400 (EDT)	[thread overview]
Message-ID: <882847003.325886.1464098472012.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20160524074936.11253-1-bxue@redhat.com>





----- Original Message -----
> From: "Boyang Xue" <bxue@redhat.com>
> To: ltp@lists.linux.it
> Sent: Tuesday, 24 May, 2016 9:49:36 AM
> Subject: [LTP] [PATCH v1 1/1] test_robind: add "-f" mkfs option for xfs and	btrfs
> 
> Add "-f" mkfs option for xfs and btrfs to aid the failure in creating
> filesystem due to commit a7f854472ebc ("tst_mkfs: drop -f from mkfs").
> 
> Signed-off-by: Boyang Xue <bxue@redhat.com>

Alternative would be to zero-erase first blocks of LTP_BIG_DEV
in runltp, but I'm not sure we want to assume that all tests
are going to write over it.

I found only 3 tests using LTP_BIG_DEV, this is the only
one that is using xfs/btrfs, the other two are ext3/4.

So, this is fine by me, ACK.
@Stanislav: Any thoughts?

Regards,
Jan

> ---
>  testcases/kernel/fs/fs_readonly/test_robind.sh | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/testcases/kernel/fs/fs_readonly/test_robind.sh
> b/testcases/kernel/fs/fs_readonly/test_robind.sh
> index dfe6f7e..181ae9e 100755
> --- a/testcases/kernel/fs/fs_readonly/test_robind.sh
> +++ b/testcases/kernel/fs/fs_readonly/test_robind.sh
> @@ -198,6 +198,10 @@ for fstype in $FSTYPES; do
>  		opts="-f --journal-size 513 -q"
>  	elif echo "$fstype" | grep -q "ext"; then
>  		opts="-F"
> +	elif [ "$fstype" = "xfs" ]; then
> +		opts="-f"
> +	elif [ "$fstype" = "btrfs" ]; then
> +		opts="-f"
>  	fi
>  
>  	if [ "$fstype" != "ramfs" ]; then
> --
> 2.8.3
> 
> 
> --
> Mailing list info: https://lists.linux.it/listinfo/ltp
> 

  reply	other threads:[~2016-05-24 14:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-24  7:49 [LTP] [PATCH v1 1/1] test_robind: add "-f" mkfs option for xfs and btrfs Boyang Xue
2016-05-24 14:01 ` Jan Stancek [this message]
2016-05-24 15:26   ` Cyril Hrubis
2016-05-25  6:31     ` Jan Stancek
2016-05-25  7:05       ` Stanislav Kholmanskikh
2016-05-25 14:10         ` Cyril Hrubis
2016-06-17  4:28         ` Eryu Guan
2016-06-21 10:51           ` Stanislav Kholmanskikh
2016-06-21 10:59             ` Eryu Guan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=882847003.325886.1464098472012.JavaMail.zimbra@redhat.com \
    --to=jstancek@redhat.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox