From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] syscalls/move_pages: move_pages() can return positive value
Date: Tue, 28 Aug 2018 06:40:24 -0400 (EDT) [thread overview]
Message-ID: <889878276.43118765.1535452824435.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <1957638804.43116794.1535451580327.JavaMail.zimbra@redhat.com>
----- Original Message -----
>
> ----- Original Message -----
> > Hi!
> > > ret = numa_move_pages(0, TEST_PAGES, pages, NULL, status, 0);
> > > - if (ret != 0) {
> > > + if (ret == -1) {
> >
> > Maybe we should go for (ret < 0) but other than that this looks good.
>
> Agreed, we don't check for other negative values, so we better report
> those as failures too.
Pushed with suggested change and your ACK.
Regards,
Jan
prev parent reply other threads:[~2018-08-28 10:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-27 13:37 [LTP] [PATCH] syscalls/move_pages: move_pages() can return positive value Jan Stancek
2018-08-28 10:00 ` Cyril Hrubis
2018-08-28 10:19 ` Jan Stancek
2018-08-28 10:40 ` Jan Stancek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=889878276.43118765.1535452824435.JavaMail.zimbra@redhat.com \
--to=jstancek@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox