public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Alexey Kodanev <alexey.kodanev@oracle.com>
To: ltp@lists.linux.it
Subject: [LTP] [RFC PATCH v5 0/3] Simplify network setup
Date: Thu, 4 May 2017 14:09:46 +0300	[thread overview]
Message-ID: <8a43347a-716f-7ce6-2758-e5eda838e265@oracle.com> (raw)
In-Reply-To: <20170503160751.1634-1-pvorel@suse.cz>

On 03.05.2017 19:07, Petr Vorel wrote:
> Hi,
>
> another version of tst_net_vars network setup helper.
> v4->v5:
> * Clenup unneded variables (reverse IP related).
> * Don't require to have mask in IP address. Use netlink to detect prefix when
>   address is presented on some of the NIC on the system or fallback to default
>   ones (24 for IPv4, 64 for IPv6).
> * Fix detecting wrong subnet with network not round up by 8 (IPv4 resp 16
>   (IPv6). E.g.: problem IP addressed like 10.2.0.1/22 10.2.1.1/22.
> * Add more environment variables (e.g. prefix, whole IP address)
> * Rewritten (again) unused network generation to fix overlap with used IP addresses.
> * Simplify tst_ipaddr() (in testcases/lib/test_net.sh).
> * Use tst_brk() to exit on error.
> * Cleanup warnings and formatting.
>
> There is still requirement network prefix to be < 8 (IPv4) resp. 16 (IPv6) as
> then IPV{4,6}_NETWORK variables would be empty, which is not expected by tests
> (they join it with address separators with {L,R}HOST_IPV{4,6}_HOST. Even we got
> rid of reverse related variables we still need IPV{4,6}_NETWORK variables for
> some tests.

Hi Petr,

But you removed such dependency on the prefix from test_net.sh  in
the third patch... so we could just print the warning that configuration
is not appropriate for the old tests, that is for stress/multicast,
stress/route groups only.

Thanks,
Alexey


  parent reply	other threads:[~2017-05-04 11:09 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-03 16:07 [LTP] [RFC PATCH v5 0/3] Simplify network setup Petr Vorel
2017-05-03 16:07 ` [LTP] [RFC PATCH v5 1/3] gitignore: Prefixing filenames Petr Vorel
2017-05-03 16:07 ` [LTP] [RFC PATCH v5 2/3] network: Add tool for setup IP variables Petr Vorel
2017-05-04 14:41   ` Richard Palethorpe
2017-05-04 19:51     ` Petr Vorel
2017-05-03 16:07 ` [LTP] [RFC PATCH v5 3/3] network: Use tst_net_vars to set up IPv4 and IPv6 related variables Petr Vorel
2017-05-04 11:09 ` Alexey Kodanev [this message]
2017-05-04 12:42   ` [LTP] [RFC PATCH v5 0/3] Simplify network setup Alexey Kodanev
2017-05-04 14:03     ` Petr Vorel
2017-05-04 13:46   ` Petr Vorel
2017-05-04 14:52     ` Alexey Kodanev
2017-05-04 19:25       ` Petr Vorel
2017-05-04 11:27 ` Richard Palethorpe
2017-05-04 12:35   ` Alexey Kodanev
2017-05-04 13:38     ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8a43347a-716f-7ce6-2758-e5eda838e265@oracle.com \
    --to=alexey.kodanev@oracle.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox