From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [RFC] [PATCH] commands/which01.sh: Fix test for debian.
Date: Thu, 4 May 2017 15:07:28 -0400 (EDT) [thread overview]
Message-ID: <94622407.7415649.1493924848056.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20170503145016.27519-1-chrubis@suse.cz>
----- Original Message -----
> The which binary on Debian comes from debianutils package and not from
> the which package (like it is on the most of the distros). It does not
> support most of the options, which is fine, since the test produces
> TCONF for these but also returns relative path instead of absolute one.
>
> So this patch adds alternate version for the expected path and the test
> passes if at least one of them matches.
>
> Fixes #151.
>
> Signed-off-by: Cyril Hrubis <chrubis@suse.cz>
No objections - I think we used same approach in file test.
I'd add also that note about POSIX not defining it to commit message.
Regards,
Jan
next prev parent reply other threads:[~2017-05-04 19:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-03 14:50 [LTP] [RFC] [PATCH] commands/which01.sh: Fix test for debian Cyril Hrubis
2017-05-04 19:07 ` Jan Stancek [this message]
2017-05-05 9:18 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94622407.7415649.1493924848056.JavaMail.zimbra@redhat.com \
--to=jstancek@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox