From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] numa_node_size: drop definition of numa_exit_on_error
Date: Thu, 28 Jan 2016 09:45:45 -0500 (EST) [thread overview]
Message-ID: <952947167.13501619.1453992345342.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20160128134127.GA3101@rei>
----- Original Message -----
> From: "Cyril Hrubis" <chrubis@suse.cz>
> To: "Jan Stancek" <jstancek@redhat.com>
> Cc: ltp@lists.linux.it
> Sent: Thursday, 28 January, 2016 2:41:27 PM
> Subject: Re: [LTP] [PATCH] numa_node_size: drop definition of numa_exit_on_error
>
> Hi!
> > numa_exit_on_error is defined by numactl library in libnuma.c,
> > at least since version 0.9. Re-defining it in test can cause
> > compile problems.
>
> I've tried to rebuild LTP without the line in question on couple of SUSE
> distros and it haven't caused any problems. I wonder why it wasn't
> failing the compilation before though, the variable is defined right in
> the libnuma.c in the library.
Linker doesn't seem to mind when linking against shared library.
His build had --static, so I'm guessing noone has tried (and reported) that before.
Regards,
Jan
>
> --
> Cyril Hrubis
> chrubis@suse.cz
>
prev parent reply other threads:[~2016-01-28 14:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 11:40 [LTP] [PATCH] numa_node_size: drop definition of numa_exit_on_error Jan Stancek
2016-01-28 13:41 ` Cyril Hrubis
2016-01-28 14:45 ` Jan Stancek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=952947167.13501619.1453992345342.JavaMail.zimbra@redhat.com \
--to=jstancek@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox