public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Disha Goel <disgoel@linux.ibm.com>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] syscalls/ustat: Skip tests on Btrfs using TCONF
Date: Mon, 23 Mar 2026 14:13:04 +0530	[thread overview]
Message-ID: <992deb3d-747b-4d9c-8f53-bee9cf5c6f01@linux.ibm.com> (raw)
In-Reply-To: <abwlWjOGbIUIZLbe@yuki.lan>

On 19/03/26 10:03 pm, Cyril Hrubis wrote:
> Hi!
>> The ustat(2) system call is known to fail with EINVAL on Btrfs because
>> it uses anonymous device IDs for subvolumes, which the legacy syscall
>> cannot resolve to a physical block device.
>>
>> Currently, this results in a TFAIL, which causes false negatives in
>> automated CI environments (e.g., SLES). This patch adds dynamic
>> filesystem detection in setup() and uses tst_brk(TCONF, ...) to
>> gracefully skip the test on Btrfs.
> 
> That's why the test has known-fail tag, but maybe it's time to accept
> that ustat() is broken on Btrfs and it's not going to get fixed.
> 
> However we do have .skip_filesystems in tst_test structure exactly for
> cases like that, so it should be used instead.
> 
Hi Cyril,

Thank you for the review.

I will refactor both ustat01 and ustat02 to use .skip_filesystems and 
send a v2.

-- 
Regards,
Disha


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

      reply	other threads:[~2026-03-23  8:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-18  8:24 [LTP] [PATCH] syscalls/ustat: Skip tests on Btrfs using TCONF Disha Goel
2026-03-19 16:33 ` Cyril Hrubis
2026-03-23  8:43   ` Disha Goel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=992deb3d-747b-4d9c-8f53-bee9cf5c6f01@linux.ibm.com \
    --to=disgoel@linux.ibm.com \
    --cc=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox