From: Andrea Cervesato via ltp <ltp@lists.linux.it>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2] statmount.h: add check for STATMOUNT_MNT_NS_ID
Date: Fri, 26 Sep 2025 10:13:24 +0200 [thread overview]
Message-ID: <9da94554-faae-4864-8908-c1484ee55ac4@suse.com> (raw)
In-Reply-To: <aNZI_qWdLSLAz5pH@yuki.lan>
On 9/26/25 10:04 AM, Cyril Hrubis wrote:
> This has to be unfortunately there because the field is present if we
> are using lapi fallback or if we have new enough system headers. So
> either we open code the ifdefs in the test, or define the macro like
> this.
Why not just using "#if!defined(HAVE_STRUCT_STATMOUNT) ||
defined(HAVE_STRUCT_STATMOUNT_MNT_NS_ID)" inside the statmount09 test
then? These LTP_HAVE_* wrappers are a bit weird because they are mixing
with internal LTP macros, also considering the fact we are not testing
"struct statmount.mnt_ns_id" anywhere else but in statmount09.
--
Andrea Cervesato
andrea.cervesato@suse.com
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2025-09-26 8:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-26 4:07 [LTP] [PATCH v2] statmount.h: add check for STATMOUNT_MNT_NS_ID Jack Morgan
2025-09-26 4:07 ` [LTP] [PATCH v2] statmount09.c: Enable mnt_ns_id " Jack Morgan
2025-09-26 7:32 ` Andrea Cervesato via ltp
2025-09-26 7:40 ` Andrea Cervesato via ltp
2025-09-26 8:17 ` Cyril Hrubis
2025-09-26 8:22 ` Andrea Cervesato via ltp
2025-09-26 20:31 ` Jack Morgan
2025-09-26 7:33 ` [LTP] [PATCH v2] statmount.h: add check " Andrea Cervesato via ltp
2025-09-26 8:04 ` Cyril Hrubis
2025-09-26 8:13 ` Andrea Cervesato via ltp [this message]
2025-09-26 8:18 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9da94554-faae-4864-8908-c1484ee55ac4@suse.com \
--to=ltp@lists.linux.it \
--cc=andrea.cervesato@suse.com \
--cc=chrubis@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox