Re: [LTP] [PATCH 3/3, v2] ltp: fix warnings in "fsstress.c"

[Garrett Cooper <yanegomi@gmail.com>]

On Mon, Apr 11, 2011 at 11:32 AM, Alex Elder <aelder@sgi.com> wrote:
> Fix remaining warnings in "testcases/kernel/fs/fsstress/fsstress.c".
> Three of them are due to mismatches between fprintf() conversion
> specifications and the variables being formatted.  Fix these by
> casting the variables to the right type.
>
> Two others are due to the use of a __uint64_t local variable to
> represent a value of type __u64 (which evidently can be defined
> differently in some environments).  Fix these by using the exact
> matching type in the cases that produce the warning messages.
>
> Updated to address the concern raised by Garrett Cooper about the
> use of types that are not identical to what's used in the XFS
> ioctl() interface in the kernel.  Also added memset() calls so we're
> sure no garbage resides in data structures passed between user space
> and the kernel.

1. Please use sizeof() instead of bareword sizeof.
2. I'm not sure if this is necessarily LKML style (the code I've
sampled in the mainline kernel do this however), but casts don't
require spurious spaces in FreeBSD for instance, i.e.

    foo = (void*)bar;

instead of

    foo = (void*) bar;

Cheers,
-Garrett

------------------------------------------------------------------------------
Forrester Wave Report - Recovery time is now measured in hours and minutes
not days. Key insights are discussed in the 2010 Forrester Wave Report as
part of an in-depth evaluation of disaster recovery service providers.
Forrester found the best-in-class provider in terms of services and vision.
Read this report now!  http://p.sf.net/sfu/ibm-webcastpromo
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list