Re: [LTP] [PATCH v3 3/4] Makefile: Update 'doc' target, add 'doc-clean'

["Ricardo B. Marli��re via ltp" <ltp@lists.linux.it>]

On Mon Mar 24, 2025 at 8:40 PM -03, Petr Vorel wrote:
> 'doc' target previously run docparse documentation. Point it to doc/
> directory so that it build sphinx docs. doc/ dir has metadata/ dir as
> dependency, no need to specify it. Call also '.venv' target.
>
> NOTE: it's still possible to avoid virtualenv by calling 'make -C doc'

From the root dir ?

$ make -C doc
make: Entering directory '/mnt/ext/src/linux/ltp/mail/doc'
make -C /mnt/ext/src/linux/ltp/mail/metadata
make[1]: Entering directory '/mnt/ext/src/linux/ltp/mail/metadata'
/mnt/ext/src/linux/ltp/mail/metadata/parse.sh > ltp.json
make[1]: Leaving directory '/mnt/ext/src/linux/ltp/mail/metadata'
if [ -d .venv ]; then . .venv/bin/activate; fi; sphinx-build -b html . html
/bin/sh: line 1: sphinx-build: command not found
make: *** [Makefile:24: all] Error 127
make: Leaving directory '/mnt/ext/src/linux/ltp/mail/doc'

>
> Add 'doc-clean': to remove only generated data (not optional .venv).
>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> Changes since v2:
> * 'doc' target: call also '.venv' target
> * Add 'doc-clean' target
>
>  Makefile | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 5066789349..0c572248a4 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -169,8 +169,14 @@ INSTALL_TARGETS		+= $(addprefix $(DESTDIR)/$(bindir)/,$(BINDIR_INSTALL_SCRIPTS))
>  
>  $(INSTALL_TARGETS): $(INSTALL_DIR) $(DESTDIR)/$(bindir)
>  
> -.PHONY: doc
> -doc: metadata-all
> +.PHONY: doc doc-clean
> +
> +doc:
> +	$(MAKE) -C $(abs_builddir)/doc .venv
> +	$(MAKE) -C $(abs_builddir)/doc
> +
> +doc-clean:
> +	$(MAKE) -C $(abs_builddir)/doc clean
>  
>  .PHONY: check
>  check: $(CHECK_TARGETS)


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp