From: "Ricardo B. Marli��re via ltp" <ltp@lists.linux.it>
To: "Petr Vorel" <pvorel@suse.cz>
Cc: Linux Test Project <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH 3/4] include/Makefile: Fix cleaning targets
Date: Tue, 01 Apr 2025 11:43:44 -0300 [thread overview]
Message-ID: <D8VDRQTQRJJ7.2GET721U22NIL@suse.com> (raw)
In-Reply-To: <20250401074726.GE299271@pevik>
On Tue Apr 1, 2025 at 4:47 AM -03, Petr Vorel wrote:
> Hi Ricardo,
>
>> Add ac-clean target as dependency of ac-maintainer-clean and add missing
>> files to the removal list. This way the project top level Makefile cleaning
>> targets can make use of it.
>
>> Cc: Andrea Cervesato <andrea.cervesato@suse.com>
>> Fixes: 817d8095fbfe ("Rename linux_syscall_numbers.h to lapi/syscalls.h")
>
> I did not get how this commit broke the functionality.
It did not break anything, but either that commit or the one that added
the older "linux_syscall_numbers.h" file should have also marked it for
removal. Should I drop the Fixes: tag?
>
> Change LGTM.
>
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
Thanks,
- Ricardo.
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2025-04-01 14:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-27 21:56 [LTP] [PATCH 0/4] configure: Tidy up removal of generated artifacts Ricardo B. Marliere via ltp
2025-03-27 21:56 ` [LTP] [PATCH 1/4] configure: Add missing include/mk/config-openposix.mk reference Ricardo B. Marliere via ltp
2025-03-28 10:31 ` Cyril Hrubis
2025-04-01 7:24 ` Petr Vorel
2025-03-27 21:56 ` [LTP] [PATCH 2/4] openposix: Makefile: Add the standard "maintainer-clean" target Ricardo B. Marliere via ltp
2025-04-01 7:38 ` Petr Vorel
2025-04-01 14:40 ` Ricardo B. Marli��re via ltp
2025-03-27 21:56 ` [LTP] [PATCH 3/4] include/Makefile: Fix cleaning targets Ricardo B. Marliere via ltp
2025-04-01 7:47 ` Petr Vorel
2025-04-01 14:43 ` Ricardo B. Marli��re via ltp [this message]
2025-04-01 19:35 ` Petr Vorel
2025-03-27 21:56 ` [LTP] [PATCH 4/4] configure: Add missing files for removal in ac-maintainer-clean target Ricardo B. Marliere via ltp
2025-04-01 7:58 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D8VDRQTQRJJ7.2GET721U22NIL@suse.com \
--to=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
--cc=rbm@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox