Re: [LTP] [PATCH v2] openposix: update invalid clock id to accomodate new auxiliary clock ids

[Andrea Cervesato via ltp <ltp@lists.linux.it>]

Hi!

On Tue Oct 7, 2025 at 11:37 PM CEST, Petr Vorel wrote:
>> On Tuesday, October 7, 2025 4:32:06 PM CEST Avinesh Kumar wrote:
>> > Starting kernel v6.17, there are 8 more auxiliary clock ids reserved on
>> > systems with CONFIG_POSIX_AUX_CLOCK=y [1] and moreover posix systems can
>> > define and support any number of clocks beyond the mandatory ones.
>
>> > [1] https://lore.kernel.org/lkml/20250519083025.905800695@linutronix.de/
>
>> > Signed-off-by: Avinesh Kumar <akumar@suse.de>
>> > ---
>> >  .../conformance/interfaces/clock_getres/6-2.c                | 5 ++---
>> >  .../conformance/interfaces/clock_gettime/8-2.c               | 4 ++--
>> >  .../conformance/interfaces/clock_settime/17-2.c              | 4 ++--
>> >  3 files changed, 6 insertions(+), 7 deletions(-)
>
>> > diff --git a/testcases/open_posix_testsuite/conformance/interfaces/clock_getres/6-2.c b/testcases/open_posix_testsuite/conformance/interfaces/clock_getres/6-2.c
>> > index c44809012..af45e27c9 100644
>> > --- a/testcases/open_posix_testsuite/conformance/interfaces/clock_getres/6-2.c
>> > +++ b/testcases/open_posix_testsuite/conformance/interfaces/clock_getres/6-2.c
>> > @@ -17,8 +17,7 @@
>> >   *   unassigned value = -1073743192 (ex. of what gcc will set to)
>> >   *   unassigned value = 1073743192 (ex. of what gcc will set to)
>> >   *   -1
>> > - *   17 (currently not = to any clock)
>> > - *
>> > + *   50 (hopefully big enough value not to be a valid clock id)
>> >   */
>> >  #include <stdio.h>
>> >  #include <time.h>
>> > @@ -33,7 +32,7 @@ int main(void)
>> >  	struct timespec res;
>> >  	int invalid_tests[NUMINVALIDTESTS] = {
>> >  		INT32_MIN, INT32_MAX, 2147483647, -2147483647, -1073743192,
>> > -		1073743192, -1, 17
>> > +		1073743192, -1, 50
>> >  	};
>> >  	int i;
>> >  	int failure = 0;
>> > diff --git a/testcases/open_posix_testsuite/conformance/interfaces/clock_gettime/8-2.c b/testcases/open_posix_testsuite/conformance/interfaces/clock_gettime/8-2.c
>> > index ed4cd4078..92263ce87 100644
>> > --- a/testcases/open_posix_testsuite/conformance/interfaces/clock_gettime/8-2.c
>> > +++ b/testcases/open_posix_testsuite/conformance/interfaces/clock_gettime/8-2.c
>> > @@ -15,7 +15,7 @@
>> >   *   unassigned value = -1073743192 (ex. of what gcc will set to)
>> >   *   unassigned value = 1073743192 (ex. of what gcc will set to)
>> >   *   -1
>> > - *   17 (currently not = to any clock)
>> > +  *   50 (hopefully big enough value not to be a valid clock id)
>> I see I added extra space in this one, please fix while merging if patch is fine.
>
> Sure, np.
>
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
>
> Kind regards,
> Petr
>
>> Thanks,
>> Avinesh

Maybe we should merge this patch, WDYT?

Acked-by: Andrea Cervesato <andrea.cervesato@suse.com>


-- 
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp