Re: [LTP] [PATCH] ioctl_pidfd02-06: Add CONFIG_USER_NS and CONFIG_PID_NS to needs_kconfigs

[Andrea Cervesato via ltp <ltp@lists.linux.it>]

> And https://www.man7.org/linux/man-pages/man7/user_namespaces.7.html.
>
> Yeah, I understand that. The dependency of CLONE_NEWUSER/CLONE_NEWPID is also
> visible in kernel sources (e.g. fs/nsfs.c). But my question was different:
> Do we now prefer everything kind of document with .needs_kconfigs, even it's
> possible to detect it otherwise? (speed of parsing kconfig, kind of hard request
> for kconfig being available even we can figure the support otherwise).

I believe we shouldn't see this as black/white but use this feature when
it's really needed. This is the case.

>
> And if we decide for forcing kconfig, we should update ioctl_ns06.c, which does
> /proc based detection (i.e. to use the same approach).

I didn't check this, but I'm pretty sure we should go all around and
verify many other tests with the same issue. We should do it in this
patch-set or on a searate one.

>
> Kind regards,
> Petr


-- 
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp