* [LTP] [PATCH v1] Add config check for systems that do not support CONFIG_XFS_FS.
@ 2025-11-04 19:39 Stephen Bertram via ltp
2025-11-05 10:55 ` Cyril Hrubis
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Bertram via ltp @ 2025-11-04 19:39 UTC (permalink / raw)
To: ltp; +Cc: Stephen Bertram
---
testcases/kernel/syscalls/file_attr/file_attr02.c | 4 ++++
testcases/kernel/syscalls/file_attr/file_attr03.c | 4 ++++
2 files changed, 8 insertions(+)
diff --git a/testcases/kernel/syscalls/file_attr/file_attr02.c b/testcases/kernel/syscalls/file_attr/file_attr02.c
index f6625985a..a1c459d30 100644
--- a/testcases/kernel/syscalls/file_attr/file_attr02.c
+++ b/testcases/kernel/syscalls/file_attr/file_attr02.c
@@ -102,6 +102,10 @@ static struct tst_test test = {
},
{}
},
+ .needs_kconfigs = (const char *[]) {
+ "CONFIG_XFS_FS",
+ NULL
+ },
.bufs = (struct tst_buffers []) {
{&attr, .size = sizeof(struct file_attr)},
{}
diff --git a/testcases/kernel/syscalls/file_attr/file_attr03.c b/testcases/kernel/syscalls/file_attr/file_attr03.c
index 9ad779041..19a8e298d 100644
--- a/testcases/kernel/syscalls/file_attr/file_attr03.c
+++ b/testcases/kernel/syscalls/file_attr/file_attr03.c
@@ -69,6 +69,10 @@ static struct tst_test test = {
{.type = "xfs"},
{}
},
+ .needs_kconfigs = (const char *[]) {
+ "CONFIG_XFS_FS",
+ NULL
+ },
.bufs = (struct tst_buffers []) {
{&attr, .size = sizeof(struct file_attr)},
{}
--
2.49.0
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [LTP] [PATCH v1] Add config check for systems that do not support CONFIG_XFS_FS.
2025-11-04 19:39 [LTP] [PATCH v1] Add config check for systems that do not support CONFIG_XFS_FS Stephen Bertram via ltp
@ 2025-11-05 10:55 ` Cyril Hrubis
2026-01-08 8:35 ` Andrea Cervesato via ltp
0 siblings, 1 reply; 4+ messages in thread
From: Cyril Hrubis @ 2025-11-05 10:55 UTC (permalink / raw)
To: Stephen Bertram; +Cc: ltp
Hi!
There was a bug in the test library filesystem availability check,
should have been fixed by:
commit 5e1e0e2d81e564df09542b7caa2a66928c05dd3a
Author: Cyril Hrubis <chrubis@suse.cz>
Date: Mon Oct 27 16:09:24 2025 +0100
lib/tst_test: Fix FS kernel supported check
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [LTP] [PATCH v1] Add config check for systems that do not support CONFIG_XFS_FS.
2025-11-05 10:55 ` Cyril Hrubis
@ 2026-01-08 8:35 ` Andrea Cervesato via ltp
2026-01-08 13:33 ` Stephen Bertram via ltp
0 siblings, 1 reply; 4+ messages in thread
From: Andrea Cervesato via ltp @ 2026-01-08 8:35 UTC (permalink / raw)
To: Cyril Hrubis, Stephen Bertram; +Cc: ltp
Hi!
On Wed Nov 5, 2025 at 11:55 AM CET, Cyril Hrubis wrote:
> Hi!
> There was a bug in the test library filesystem availability check,
> should have been fixed by:
>
> commit 5e1e0e2d81e564df09542b7caa2a66928c05dd3a
> Author: Cyril Hrubis <chrubis@suse.cz>
> Date: Mon Oct 27 16:09:24 2025 +0100
>
> lib/tst_test: Fix FS kernel supported check
Should we reject the patch?
--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [LTP] [PATCH v1] Add config check for systems that do not support CONFIG_XFS_FS.
2026-01-08 8:35 ` Andrea Cervesato via ltp
@ 2026-01-08 13:33 ` Stephen Bertram via ltp
0 siblings, 0 replies; 4+ messages in thread
From: Stephen Bertram via ltp @ 2026-01-08 13:33 UTC (permalink / raw)
To: Andrea Cervesato; +Cc: ltp
Yes, please!
stephen
He/His/Him
On Thu, Jan 8, 2026 at 3:36 AM Andrea Cervesato <andrea.cervesato@suse.com>
wrote:
> Hi!
>
> On Wed Nov 5, 2025 at 11:55 AM CET, Cyril Hrubis wrote:
> > Hi!
> > There was a bug in the test library filesystem availability check,
> > should have been fixed by:
> >
> > commit 5e1e0e2d81e564df09542b7caa2a66928c05dd3a
> > Author: Cyril Hrubis <chrubis@suse.cz>
> > Date: Mon Oct 27 16:09:24 2025 +0100
> >
> > lib/tst_test: Fix FS kernel supported check
>
> Should we reject the patch?
>
> --
> Andrea Cervesato
> SUSE QE Automation Engineer Linux
> andrea.cervesato@suse.com
>
>
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-01-08 13:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-04 19:39 [LTP] [PATCH v1] Add config check for systems that do not support CONFIG_XFS_FS Stephen Bertram via ltp
2025-11-05 10:55 ` Cyril Hrubis
2026-01-08 8:35 ` Andrea Cervesato via ltp
2026-01-08 13:33 ` Stephen Bertram via ltp
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox