public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Andrea Cervesato via ltp <ltp@lists.linux.it>
To: "Cyril Hrubis" <chrubis@suse.cz>,
	"Andrea Cervesato" <andrea.cervesato@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2] syscalls: add file_attr05 test
Date: Mon, 19 Jan 2026 15:03:12 +0100	[thread overview]
Message-ID: <DFSMEBM9PYDT.3TJXEU3C8W31R@suse.com> (raw)
In-Reply-To: <aW4mDAH6pVh_VyC2@yuki.lan>

Hi!

On Mon Jan 19, 2026 at 1:39 PM CET, Cyril Hrubis wrote:
> Hi!
> > +	.filesystems = (struct tst_fs []) {
> > +		{.type = "vfat"},
>
> I wonder if we can add more filesystems here, just to make sure that we
> run the test even when vfat is not compiled in the kernel. Does ext2
> implement the file_set/getattr calls?
>
> > +		{}
> > +	},
>
> Reviewed-by: Cyril Hrubis <chrubis@suse.cz>

vfat and ntfs are the only ones which don't support both file_setattr()
and file_getattr(), while ext family, tmpfs and btrfs don't raise
EOPNOTSUPP for file_getattr() only. I'm wondering if that's a bug, since
xfs is our reference for this implementation, or this has been
introduced in 6.18-rc2 by 7ea30958b3054f5e488fa0b33c352723f7ab3a2a
commit.

-- 
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2026-01-19 14:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-14  7:58 [LTP] [PATCH v2] syscalls: add file_attr05 test Andrea Cervesato
2026-01-16 11:20 ` Li Wang via ltp
2026-01-19 12:39 ` Cyril Hrubis
2026-01-19 14:03   ` Andrea Cervesato via ltp [this message]
2026-01-20  9:59     ` Petr Vorel
2026-01-20 10:43       ` Andrea Cervesato via ltp
2026-01-20 10:55         ` Andrea Cervesato via ltp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DFSMEBM9PYDT.3TJXEU3C8W31R@suse.com \
    --to=ltp@lists.linux.it \
    --cc=andrea.cervesato@suse.com \
    --cc=andrea.cervesato@suse.de \
    --cc=chrubis@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox