[LTP] [PATCH 1/1] runltp: fix regex for disabled testcases

[LTP] [PATCH 1/1] runltp: fix regex for disabled testcases

[Vasileios Almpanis via ltp]

Currently for all disabled testcases we append TCONF
so that they don't completely disappear from the results.
Unfortunately this regex also matches comments that
include the testcase name creating multiple results for the
same testcase as with the folloing example.

  sed -n '/\<cgroup\>/p' runtest/controllers
  cgroup		cgroup_regression_test.sh
  # Stress test for debug cgroup
  # Stress test for cpuset cgroup
  # Stress test for cpu cgroup
  # Stress test for cpuacct cgroup
  # Stress test for memory cgroup
  # Stress test for freezer cgroup
  # Stress test for devices cgroup
  # Stress test for blkio cgroup
  # Stress test for net_cls cgroup
  # Stress test for perf_event cgroup
  # Stress test for net_prio cgroup
  # Stress test for hugetlb cgroup

Add a line anchor to the regex to not match
lines not related to the disabled testcases.

Signed-off-by: Vasileios Almpanis <vasileios.almpanis@virtuozzo.com>
---
 runltp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/runltp b/runltp
index 0d9062569..e1748e493 100755
--- a/runltp
+++ b/runltp
@@ -650,7 +650,7 @@ EOF
     if [ -n "${SKIPFILE}" ]; then
         for test_name in $(awk '{print $1}' "${SKIPFILE}"); do
             case "${test_name}" in \#*) continue;; esac
-            sed -i "/\<${test_name}\>/c\\${test_name} exit 32;" alltests
+            sed -i "/^\<${test_name}\>/c\\${test_name} exit 32;" alltests
         done
     fi
 
-- 
2.43.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 1/1] runltp: fix regex for disabled testcases

[Andrea Cervesato via ltp]

Hi!

We are not supporting runltp anymore, as you can read in the
documentation: 
https://linux-test-project.readthedocs.io/en/latest/developers/todo.html#fade-out-old-tests-runner

And from its execution:

	~ $ /opt/ltp/runltp --help
	-------------------------------------------
	INFO: runltp script is deprecated, try kirk
	https://github.com/linux-test-project/kirk

Please use kirk instead, which is included in the LTP releases and it
can be installed it via pip/sources:
https://kirk.readthedocs.io/en/latest/users/quickstart.html

King regards,
-- 
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 1/1] runltp: fix regex for disabled testcases

[Cyril Hrubis]

Hi!
> We are not supporting runltp anymore, as you can read in the
> documentation: 

Kirk has been stable for some time, I suppose that it's about the time
we finally remove runltp from LTP.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 1/1] runltp: fix regex for disabled testcases

[Li Wang via ltp]

> Kirk has been stable for some time, I suppose that it's about the time
> we finally remove runltp from LTP.

+1

Regards,
Li Wang


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 1/1] runltp: fix regex for disabled testcases

[Petr Vorel]

> > Kirk has been stable for some time, I suppose that it's about the time
> > we finally remove runltp from LTP.

> +1

Very good point, patchset posted:
https://lore.kernel.org/ltp/20260204115339.224261-1-pvorel@suse.cz/T/#t
https://patchwork.ozlabs.org/project/ltp/list/?series=490958&state=*

Kind regards,
Petr

> Regards,
> Li Wang

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp