From: Andrea Cervesato via ltp <ltp@lists.linux.it>
To: "Jinseok Kim" <always.starving0@gmail.com>, <pvorel@suse.cz>,
<ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH] inotify: cleanup - limit masks, use SAFE_ wrappers
Date: Tue, 17 Feb 2026 14:29:23 +0100 [thread overview]
Message-ID: <DGH9U8LALY49.15D20CTE4T52F@suse.com> (raw)
In-Reply-To: <20260216165015.1710-1-always.starving0@gmail.com>
On Mon Feb 16, 2026 at 5:50 PM CET, Jinseok Kim wrote:
> Hi Vorel,
>
> Thanks for the review!
>
> - inotify12.c needs read() because EAGAIN (“no second event”) is a
> valid case that must be explicitly detected and treated as IN_IGNORED.
>
> - inotify07.c does not require this distinction: SAFE_READ() is enough,
> since EAGAIN just means end-of-events, while real errors are handled as
> TBROK, matching the original test intent.
>
> Best regards,
> Jinseok.
LGTM
Reviewed-by: Andrea Cervesato <andrea.cervesato@suse.com>
--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-02-17 13:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-14 17:52 [LTP] [PATCH] inotify: cleanup - limit masks, use SAFE_ wrappers Jinseok Kim
2026-02-16 10:20 ` Petr Vorel
2026-02-16 16:50 ` Jinseok Kim
2026-02-17 13:29 ` Andrea Cervesato via ltp [this message]
2026-02-19 16:08 ` Cyril Hrubis
2026-02-19 18:04 ` [LTP] [PATCH v2] " Jinseok Kim
2026-02-20 10:43 ` Cyril Hrubis
2026-02-20 14:08 ` Jinseok Kim
2026-02-20 15:05 ` Cyril Hrubis
2026-02-21 8:21 ` [LTP] [PATCH v3] inotify: modernize with " Jinseok Kim
2026-02-23 16:59 ` Cyril Hrubis
2026-02-24 13:32 ` Andrea Cervesato via ltp
2026-02-24 13:34 ` Andrea Cervesato via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DGH9U8LALY49.15D20CTE4T52F@suse.com \
--to=ltp@lists.linux.it \
--cc=always.starving0@gmail.com \
--cc=andrea.cervesato@suse.com \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox