From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A7882E9A02C for ; Wed, 18 Feb 2026 13:42:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=lists.linux.it; i=@lists.linux.it; q=dns/txt; s=picard; t=1771422122; h=mime-version : date : message-id : to : references : in-reply-to : subject : list-id : list-unsubscribe : list-archive : list-post : list-help : list-subscribe : from : reply-to : cc : content-type : content-transfer-encoding : sender : from; bh=jFviNCl3mVqHEuOb5bdJZSojk16VzJ3JZu8suEh5PV4=; b=FFDwr49JwuMFwqVMhTN753COoqBXH8IJcmPUYFkm+cMTAuomClLPxWiUAjCclwVju+eQC 2SKsBGgcCPiZIVAV6Hqa7zzf/bUhObv9mMPbWlAi9rkKD58CEJ837V5TNjijDC1JzVO9czr kFERd+3LAaz/Z0IYBmVO7KJ58jDRFaQ= Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 4F81C3D0706 for ; Wed, 18 Feb 2026 14:42:02 +0100 (CET) Received: from in-7.smtp.seeweb.it (in-7.smtp.seeweb.it [IPv6:2001:4b78:1:20::7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 176853CB3F4 for ; Wed, 18 Feb 2026 14:41:40 +0100 (CET) Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-7.smtp.seeweb.it (Postfix) with ESMTPS id 54414200758 for ; Wed, 18 Feb 2026 14:41:36 +0100 (CET) Received: by mail-wm1-x344.google.com with SMTP id 5b1f17b1804b1-4806cc07ce7so49163185e9.1 for ; Wed, 18 Feb 2026 05:41:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1771422096; x=1772026896; darn=lists.linux.it; h=in-reply-to:references:from:subject:cc:to:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=mX0ea5RWrVePWQsJoHCAtKYwKpNswCimslCZZkfjMBc=; b=J8JusVjxaBCAcPS0/HpBTetIpH6WjW2UeHbFQg6BqAmDsJ0HvYFai+UCjNwLm+Gqbq UzbZt1E0bWuN65GSfLkj4xBh48LinvVXxyPu4fmr29I7x2aLeCvh6syIGUlDbBgegJQN KWkx6JNMgOCxwNmCtYJQNSjFc/YlU97/yjWMPUsYl6/yGvgk7XC+xVMidLEAzdfB+l7u UGp0LiVJ/FpMLAv2CqCgVhsCCFUFbrt7/X85uCW1P+0oyikeqwtlq9DwgUM35gEeLhpb APCAgJMy4BbQu9YKlrnct04zONmitNsLT1paMHd4CrWKf79m6na2eGdpe2tLtsjgxvUe HHew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771422096; x=1772026896; h=in-reply-to:references:from:subject:cc:to:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=mX0ea5RWrVePWQsJoHCAtKYwKpNswCimslCZZkfjMBc=; b=FVx61rk46EnG85LSLx2eMyt6K9uV66q8k06zTuW+FGIWJ6/xqNqgTG5eH1JYV3E3iY afpnmq8TT1HKeSLHBwc3zWQYO3n21JD8aEXtN5lK0GRGiAMCF/mt8GFWe4jkU8DMiazG k0sRRj1h3C0T4zEPJMDQgjey0ENmfvmTFZtlUuTegopUy9UAt+OtQ4LyIdVR1LlgSntZ +chl/fK3WIpcQ73sCjEmfcwwRh9d/x1cPIfswZEXPW1orkQNCMrdI30PlU7mwskGEqUs zDdpmH2UYrpiQQ2HK63mMjIcSK1hYrc2ZTUtIWdVkiCdEYtpancjHTYZslUF69wivNiX FF0A== X-Gm-Message-State: AOJu0Yz1LEjARcRaBvfSjtdYPEDExv1920Fp9WFO1xif5j/CUt6UT6Xr EMPl/VxSgK4QdIMZEYhNaJe5oO/oHEuA7GGEViYnBRGgrJqeldA6RbcF6Er4q8fKcEM= X-Gm-Gg: AZuq6aLO+6u6YZr3uqefI02DsPi4pX0S/BYN7HAlKTERXIPhGzouyXF5jsEo167+8Vg 2OPBAJjUAhq4t2xgiO8N4LofX/mle8wtMIFQaU5quh8ZiVhhbSC+YwGFLzzmBZrIu+okNGAkq+C v8yJaFqSfk9jiYCA+STgURMIHYa+QQSbSjhsUDUIn/mxY0yKLOvJ+oOAWakYXJCVe8P4KReyllL j2vdGomzH5Uk7fjdqLMmaY4FFOXPjgkpmY8BGrb/3XN0scQeHLJwgIpRLhCg/LGkgoi6sOHdZfH 8t02ehCngdoPcIAEIMPB+qUi3O39HDqYcaCixRcGLUitc4RFliwQBJ48+/p15Ah5fO1Tb5WQuHa dRDNesJpjFM6DKg7TQG3gWNw4Htkb/q7JDH8R2xH8DC3rcAzKokW8fmXbUD8EylF9hWX2m54lX5 tMN5F2ORtjl0hYT9KeR6gqgBZUub5PQuTpeJMYhf4yolPFR+XtywukfiZH/4mEDu/8cp+5b/Xdj kSlSlc5zEPUWppyEWE= X-Received: by 2002:a05:600c:6992:b0:477:9eb8:97d2 with SMTP id 5b1f17b1804b1-48398a4978cmr26125965e9.8.1771422095620; Wed, 18 Feb 2026 05:41:35 -0800 (PST) Received: from localhost (p200300ef2f4fc9009ff26ae1d4042002.dip0.t-ipconnect.de. [2003:ef:2f4f:c900:9ff2:6ae1:d404:2002]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483983b7bb7sm34451965e9.4.2026.02.18.05.41.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Feb 2026 05:41:35 -0800 (PST) Mime-Version: 1.0 Date: Wed, 18 Feb 2026 14:41:34 +0100 Message-Id: To: "Petr Vorel" , "Li Wang" X-Mailer: aerc 0.18.2 References: <20260202091801.68673-1-liwang@redhat.com> <20260202101430.GA24157@pevik> In-Reply-To: <20260202101430.GA24157@pevik> X-Virus-Scanned: clamav-milter 1.0.9 at in-7.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH] doc/developers: document tst_/tse_/tso_ library namespaces X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Andrea Cervesato via ltp Reply-To: Andrea Cervesato Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! On Mon Feb 2, 2026 at 11:14 AM CET, Petr Vorel wrote: > Hi Li, > > > This helps contributors choose the correct layer when adding new library > > code and clarifies expectations around legacy components. > > > Follow-up: eef750db28 ("libs: adopt tse_ prefix for extended (non-core) library") > > Follow-up: 751df4fa64 ("include/old: rename legacy headers to tso_* namespace") > > Signed-off-by: Li Wang > > --- > > doc/developers/ltp_library.rst | 28 ++++++++++++++++++++++++++++ > > 1 file changed, 28 insertions(+) > > > diff --git a/doc/developers/ltp_library.rst b/doc/developers/ltp_library.rst > > index f76cbb75e..bb2677622 100644 > > --- a/doc/developers/ltp_library.rst > > +++ b/doc/developers/ltp_library.rst > > @@ -15,6 +15,34 @@ for :doc:`writing tests <../developers/writing_tests>` > > #. Do not add new API functions to the old API. Add new functions to > > ``tst_.[ch]`` files. > > > +Library naming and scope > > +------------------------ > > + > > +To keep the library API easy to navigate and to make layering explicit, LTP > > +library components follow these naming rules: > > + > > +- **tst_**: Core LTP library API (located in ``lib/``). > nit: maybe also use :master: for lib/ to make it clickable? > > + > > + - Stable, widely used interfaces intended for general consumption by tests. > > + - New public APIs should normally live here (in ``tst_*.h`` / ``tst_*.c``). > > + > > +- **tse_**: Non-core / extended library code (located in ``libs/``). > nit: and here as well? > > > + > > + - Optional or specialized helpers that are not part of the core API. > > + - May have narrower scope or fewer stability guarantees than ``tst_``. > > + - Can be promoted to ``tst_`` later if it becomes broadly useful and stable. > > + > > +- **tso_**: Legacy / old library code. > > + > > + - Kept for backward compatibility. > > + - No new features should be added; only minimal fixes are acceptable (e.g. build fixes, correctness fixes, security fixes). > very nit: maybe split long line? > > > + - New code should not depend on ``tso_`` unless strictly necessary. > > + > > +**Notes:** > > nit: I'd prefer the standard note (can be changed before merge): > > .. note:: > > > + > > +- Prefer adding new code to ``tst_`` or ``tse_``; avoid introducing new ``tso_`` components. > > +- When adding a new public interface, document where it belongs (``tst_`` vs ``tse_``) and why. > > LGTM, but I'd prefer more developers acked it. > > Reviewed-by: Petr Vorel > > Kind regards, > Petr With Petr suggestions, Reviewed-by: Andrea Cervesato -- Andrea Cervesato SUSE QE Automation Engineer Linux andrea.cervesato@suse.com -- Mailing list info: https://lists.linux.it/listinfo/ltp