Re: [LTP] [PATCH v2 1/2] open: fix cleanup condition and use snprintf

[Andrea Cervesato via ltp <ltp@lists.linux.it>]

Hi!

On Wed Feb 18, 2026 at 3:47 PM CET, Jinseok Kim wrote:
> Replace remaining sprintf() with snprintf() in setup()
>
> Thanks for the review.

Again, there's something wrong with your automated system. Is it LLM? :-)
The message is misleading, also because not only snprintf() touched, but
also cleanup() logic.

This has to be fixed, otherwise patch can't be accepted.

>
> Signed-off-by: Jinseok Kim <always.starving0@gmail.com>
> ---
>  testcases/kernel/syscalls/open/open04.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/testcases/kernel/syscalls/open/open04.c b/testcases/kernel/syscalls/open/open04.c
> index 3dc3486d3..5d39c1569 100644
> --- a/testcases/kernel/syscalls/open/open04.c
> +++ b/testcases/kernel/syscalls/open/open04.c
> @@ -30,7 +30,7 @@ static void setup(void)
>  	fds[0] = first;
>
>  	for (i = first + 1; i < fds_limit; i++) {
> -		sprintf(fname, FNAME ".%d", i);
> +		snprintf(fname, sizeof(fname), FNAME ".%d", i);
>  		fd = open(fname, O_RDWR | O_CREAT, 0777);
>  		if (fd == -1) {
>  			if (errno != EMFILE)
> @@ -44,13 +44,13 @@ static void setup(void)
>
>  static void run(void)
>  {
> -	sprintf(fname, FNAME ".%d", fds_limit);
> +	snprintf(fname, sizeof(fname), FNAME ".%d", fds_limit);
>  	TST_EXP_FAIL2(open(fname, O_RDWR | O_CREAT, 0777), EMFILE);
>  }
>
>  static void cleanup(void)
>  {
> -	if (!first || !fds)
> +	if (first < 0 || !fds)

And this cleanup has an issue. See below..

>  		return;
>
>  	for (i = first; i < fds_limit; i++)
> --
> 2.43.0

This test has to work also for `-i 0` option. The way we can make it
works is the following:

- "first" should be initialized to -1, otherwise "first < 0" won't be
  catched
- the fds should be initialized with -1 after SAFE_MALLOC(), otherwise
  you will fail the cleanup if malloc will break the test


Kind Regards,
-- 
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp