[LTP] [PATCH v2] cachestat02: Harden parallel worker execution.

[LTP] [PATCH v2] cachestat02: Harden parallel worker execution.

[Stephen Bertram via ltp]

This does not happen all the time but when running in parallel
sometimes one of the test instances will throw an error:
TFAIL: cs->nr_cache + cs->nr_evicted (297) != num_pages (512)

When LTP runs several instances of the cachestat tests in parallel, they share resources:
cachestat02: Uses a fixed shm name "myfile.bin". All instances use the same POSIX shared memory object.
That leads to:
Races on creation/removal of the same file/shm.
cachestat() reporting stats for a shared or partially overwritten file instead of the one the current process wrote.
nr_cache + nr_evicted not matching num_pages because the measured range is not the one written by this process.

The change is to create a unique file/shm space for each instance using the pid of each cachestat() process.
Harden parallel worker execution for cachestat02.

Signed-off-by: Stephen Bertram <sbertram@redhat.com>
---
 testcases/kernel/syscalls/cachestat/cachestat02.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/testcases/kernel/syscalls/cachestat/cachestat02.c b/testcases/kernel/syscalls/cachestat/cachestat02.c
index 72428ee83..d6505c4a4 100644
--- a/testcases/kernel/syscalls/cachestat/cachestat02.c
+++ b/testcases/kernel/syscalls/cachestat/cachestat02.c
@@ -17,10 +17,9 @@
 #include <stdlib.h>
 #include "cachestat.h"
 
-#define FILENAME "myfile.bin"
-
 static int page_size;
 static char *page_data;
+static char shm_name[64];
 static struct cachestat *cs;
 static struct cachestat_range *cs_range;
 
@@ -32,7 +31,8 @@ static void test_cached_pages(const int num_pages)
 
 	memset(cs, 0, sizeof(struct cachestat));
 
-	fd = shm_open(FILENAME, O_RDWR | O_CREAT, 0600);
+	snprintf(shm_name, sizeof(shm_name), "/cachestat_%d.bin", getpid());
+	fd = shm_open(shm_name, O_RDWR | O_CREAT | O_EXCL, 0600);
 	if (fd < 0)
 		tst_brk(TBROK | TERRNO, "shm_open error");
 
@@ -53,7 +53,7 @@ static void test_cached_pages(const int num_pages)
 	TST_EXP_EQ_LI(cs->nr_cache + cs->nr_evicted, num_pages);
 
 	SAFE_CLOSE(fd);
-	shm_unlink(FILENAME);
+	shm_unlink(shm_name);
 }
 
 static void run(void)
-- 
2.52.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH v2] cachestat02: Harden parallel worker execution.

[Cyril Hrubis]

Hi!
Reviewed-by: Cyril Hrubis <chrubis@suse.cz>

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH v2] cachestat02: Harden parallel worker execution.

[Andrea Cervesato via ltp]

Hi,

Merged thanks.
Fixed the text length inside commit that was out of the requested
80chars line length.

Reviewed-by: Andrea Cervesato <andrea.cervesato@suse.com>

Kind regards,
-- 
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp