public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Andrea Cervesato via ltp <ltp@lists.linux.it>
To: "John Stultz" <jstultz@google.com>, "Jan Polensky" <japo@linux.ibm.com>
Cc: Linux Test Project <ltp@lists.linux.it>,
	Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [LTP] [PATCH v1 1/1] sched_football: harden kickoff synchronization on high-CPU systems
Date: Wed, 25 Feb 2026 10:23:46 +0100	[thread overview]
Message-ID: <DGNXMJ74NVTB.2DY53W36K3GET@suse.com> (raw)
In-Reply-To: <CANDhNCrrZY=5bvRQGGJsigjwRNmDz8shbtM-Vtn5UkdRDGU_uA@mail.gmail.com>

On Tue Feb 24, 2026 at 10:03 PM CET, John Stultz via ltp wrote:
> On Tue, Feb 24, 2026 at 2:45 AM Jan Polensky <japo@linux.ibm.com> wrote:
> >
> > The sched_football test has been intermittently failing, most noticeably
> > on systems with many CPUs and/or under load, due to a startup ordering
> > hole around kickoff.
> >
>
> I've not had time to closely review your suggestion here, but it
> sounds reasonable.
>
> That said, I want to warn you and ensure you are aware: the
> RT_PUSH_IPI feature in the scheduler breaks the RT invariant
> sched_football is testing.
>
> I see this as a bug with that feature, but the scalability RT_PUSH_IPI
> allows for seems more important to folks who are doing RT work then
> the mis-behavior.  Steven and I talked awhile back about some ideas on
> how we might be able to do the pull in a more efficient way while
> still holding the invariant true, and I have a bug to track it, but
> its not been high enough priority to get bandwidth yet.
>
> So you might want to make sure you disable that feature before testing via:
> # echo NO_RT_PUSH_IPI > /sys/kernel/debug/sched/features
>
> thanks
> -john

Thanks for your deep analysis on the possible issue. I'm not an RT expert,
but I trust your expertise in here :-) Will leave this patch review to
someone who's more skilled than me in this topic.

I have a suggestion tho.

About the NO_RT_PUSH_IPI, we are lucky: LTP provides a safe mechanism to
set the sys configurations and to restore it to default value after
test. You can find this in the `struct tst_test` and it's called
`.save_restore` [1]

I think it's worth to force this option according to the underlying
variant (and properly document this in the code with a comment).

WDYT?

[1] https://linux-test-project.readthedocs.io/en/latest/developers/api_c_tests.html#tst-test-definition
-- 
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2026-02-25  9:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-24 10:45 [LTP] [PATCH v1 1/1] sched_football: harden kickoff synchronization on high-CPU systems Jan Polensky
2026-02-24 12:44 ` Andrea Cervesato via ltp
2026-02-24 21:03 ` John Stultz via ltp
2026-02-25  9:23   ` Andrea Cervesato via ltp [this message]
2026-02-25 19:11     ` John Stultz via ltp
2026-02-26  9:43       ` Andrea Cervesato via ltp
2026-03-02  8:56       ` Jan Polensky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DGNXMJ74NVTB.2DY53W36K3GET@suse.com \
    --to=ltp@lists.linux.it \
    --cc=andrea.cervesato@suse.com \
    --cc=japo@linux.ibm.com \
    --cc=jstultz@google.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox