From: Andrea Cervesato via ltp <ltp@lists.linux.it>
To: "Jinseok Kim" <always.starving0@gmail.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v3 2/2] fstat: add test for multiple file types using fstat
Date: Thu, 26 Feb 2026 16:44:19 +0100 [thread overview]
Message-ID: <DGP0CG3J3QK9.1M9KCELAS054F@suse.com> (raw)
In-Reply-To: <20260226153231.1513-1-always.starving0@gmail.com>
Hi,
On Thu Feb 26, 2026 at 4:32 PM CET, Jinseok Kim wrote:
> Hi,
>
> Thank you for the review.
>
> If we switch to using lstat() only, this test would no longer exercise
> fstat() at all, which changes the original intent of the test.
>
> In that case, should we consider renaming the test from fstat to lstat?
>
> Jinseok.
Sorry for the confusion...of course. The point is if we want to test
inode macros or fstat(), and of course we want to test fstat().
According to that, we should correctly use the syscall. For instance,
when using fstat():
fstat04.c:63: TFAIL: symbolic link: S_IFLNK() macro does NOT match
fstat04.c:45: TBROK: open(chrdev,2048,0000) failed: EACCES (13)
And this has to be fixed of course.
--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-02-26 15:44 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-11 17:16 [LTP] [PATCH] open: fix directory verification and misleading test description Jinseok Kim
2026-02-17 13:21 ` Andrea Cervesato via ltp
2026-02-19 10:31 ` Cyril Hrubis
2026-02-19 14:57 ` Jinseok Kim
2026-02-20 10:49 ` Cyril Hrubis
2026-02-24 7:37 ` [LTP] [PATCH 1/2] open: remove O_DIRECTORY case (move to fstat test) Jinseok Kim
2026-02-24 7:37 ` [LTP] [PATCH 2/2] Add test for multiple file types using fstat Jinseok Kim
2026-02-24 8:17 ` [LTP] [PATCH 1/2] open: remove O_DIRECTORY case (move to fstat test) Andrea Cervesato via ltp
2026-02-24 10:07 ` [LTP] [PATCH v2 " Jinseok Kim
2026-02-24 10:07 ` [LTP] [PATCH v2 2/2] fstat: add test for multiple file types using fstat Jinseok Kim
2026-02-24 14:17 ` Andrea Cervesato via ltp
2026-02-25 13:19 ` [LTP] [PATCH v3 1/2] open: remove O_DIRECTORY case (move to fstat test) Jinseok Kim
2026-02-25 13:19 ` [LTP] [PATCH v3 2/2] fstat: add test for multiple file types using fstat Jinseok Kim
2026-02-25 14:30 ` Andrea Cervesato via ltp
2026-02-26 15:32 ` Jinseok Kim
2026-02-26 15:44 ` Andrea Cervesato via ltp [this message]
2026-03-03 13:32 ` [LTP] [PATCH v4 1/2] open: remove O_DIRECTORY case (move to fstat test) Jinseok Kim
2026-03-03 13:32 ` [LTP] [PATCH v4 2/2] fstat: add test for multiple file types using fstat Jinseok Kim
2026-03-12 11:22 ` Andrea Cervesato via ltp
2026-03-13 14:07 ` Jinseok Kim
2026-03-13 15:36 ` Andrea Cervesato via ltp
2026-03-15 7:27 ` [LTP] [PATCH v5 1/2] open: remove O_DIRECTORY case (move to fstat test) Jinseok Kim
2026-03-15 7:27 ` [LTP] [PATCH v5 2/2] fstat: add test for multiple file types using fstat Jinseok Kim
2026-03-16 7:38 ` [LTP] [PATCH v5 1/2] open: remove O_DIRECTORY case (move to fstat test) Andrea Cervesato via ltp
2026-03-16 15:00 ` [LTP] [PATCH v6 " Jinseok Kim
2026-03-16 15:00 ` [LTP] [PATCH v6 2/2] fstat: add test for multiple file types using fstat Jinseok Kim
2026-03-24 12:17 ` Andrea Cervesato via ltp
2026-03-27 15:27 ` [LTP] [PATCH v7] " Jinseok Kim
2026-03-30 8:07 ` Andrea Cervesato via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DGP0CG3J3QK9.1M9KCELAS054F@suse.com \
--to=ltp@lists.linux.it \
--cc=always.starving0@gmail.com \
--cc=andrea.cervesato@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox