From: Xie Ziyao <ziyaoxie@outlook.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] gettid:Convert gettid01 to new API
Date: Tue, 31 Aug 2021 12:15:34 +0800 [thread overview]
Message-ID: <OSZP286MB08712631399F14EC1329DFEDCCCC9@OSZP286MB0871.JPNP286.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20210831024617.246758-1-threefifteen.wangkunfeng@huawei.com>
Hi, Kunfeng,
> Convert gettid01 to new API
>
> Signed-off-by: Wang Kunfeng <threefifteen.wangkunfeng@huawei.com>
> ---
> testcases/kernel/syscalls/gettid/gettid01.c | 95 ++++-----------------
> 1 file changed, 15 insertions(+), 80 deletions(-)
>
> diff --git a/testcases/kernel/syscalls/gettid/gettid01.c b/testcases/kernel/syscalls/gettid/gettid01.c
> index 7e5b6b175..2e45be588 100644
> --- a/testcases/kernel/syscalls/gettid/gettid01.c
> +++ b/testcases/kernel/syscalls/gettid/gettid01.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0
The license here should be GPL-2.0-later.
> /*
> * Crackerjack Project
> *
> @@ -6,91 +7,25 @@
> * Yumiko Sugita <yumiko.sugita.yf@hitachi.com>,
> * Satoshi Fujiwara <sa-fuji@sdl.hitachi.co.jp>
> *
> - * This program is free software; you can redistribute it and/or
> - * modify it under the terms of the GNU General Public License
> - * as published by the Free Software Foundation; either version 2
> - * of the License, or (at your option) any later version.
> - *
> - * This program is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> - * GNU General Public License for more details.
> - *
> - * You should have received a copy of the GNU General Public License
> - * along with this program; if not, write to the Free Software
> - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
> - *
> - * $Id: gettid01.c,v 1.5 2009/10/26 14:55:47 subrata_modak Exp $
> - *
> + * Porting from Crackerjack to LTP is done
> + * by Masatake YAMATO <yamato@redhat.com>
> */
>
> -/* Porting from Crackerjack to LTP is done
> - by Masatake YAMATO <yamato@redhat.com> */
> +/*\
> + * [Description]
> + *
> + * Basic test for gettid() function.
> + */
>
> #include <sys/types.h>
> -#include <linux/unistd.h>
> -#include <errno.h>
> -
> -#include "test.h"
> -
> -void setup();
> -void cleanup();
> -
> -char *TCID = "gettid01";
> -
> -int TST_TOTAL = 1;
> -
> -pid_t my_gettid(void)
> -{
> - return (pid_t) syscall(__NR_gettid);
> -}
> -
> -int main(int ac, char **av)
> -{
> - int lc;
> -
> - tst_parse_opts(ac, av, NULL, NULL);
> +#include "tst_test.h"
> +#include "lapi/syscalls.h"
>
> - setup();
> -
> - /*
> - * The following loop checks looping state if -c option given
> - */
> - for (lc = 0; TEST_LOOPING(lc); lc++) {
> -
> - tst_count = 0;
> -
> - TEST(my_gettid());
> -
> - if (TEST_RETURN == -1) {
> - tst_resm(TFAIL, "gettid() Failed, errno=%d: %s",
> - TEST_ERRNO, strerror(TEST_ERRNO));
> - } else {
> - tst_resm(TPASS, "gettid() returned %ld",
> - TEST_RETURN);
> - }
> - }
> -
> - cleanup();
> - tst_exit();
> -}
> -
> -/*
> - * setup() - performs all ONE TIME setup for this test.
> - */
> -void setup(void)
> +static void verify_gettid(void)
> {
> -
> - tst_sig(NOFORK, DEF_HANDLER, cleanup);
> -
> - TEST_PAUSE;
> -
> + TST_EXP_POSITIVE(tst_syscall(__NR_gettid), "gettid()");
> }
>
> -/*
> - * cleanup() - performs all ONE TIME cleanup for this test at
> - * completion or premature exit.
> - */
> -void cleanup(void)
> -{
> -}
> +static struct tst_test test = {
> + .test_all = verify_gettid,
> +};
> --
> 2.17.1
>
>
--
Best Regards,
Xie Ziyao
E-mail: ziyaoxie@outlook.com
next prev parent reply other threads:[~2021-08-31 4:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-31 2:46 [LTP] [PATCH] gettid:Convert gettid01 to new API Wang Kunfeng
2021-08-31 4:15 ` Xie Ziyao [this message]
2021-08-31 4:19 ` Xie Ziyao
2021-09-01 12:57 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OSZP286MB08712631399F14EC1329DFEDCCCC9@OSZP286MB0871.JPNP286.PROD.OUTLOOK.COM \
--to=ziyaoxie@outlook.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox