From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/2] lib: tst_test.c: Add TBROK counter.
Date: Tue, 8 Dec 2020 14:51:32 +0100 [thread overview]
Message-ID: <X8+E5BMEOjuVIRen@pevik> (raw)
In-Reply-To: <20201203121642.GA5809@yuki.lan>
> Hi!
> > This ensures that TBROK is never lost.
> > If test process forks a child and the child calls SAFE_MACRO() the
> > failure will be lost unless the test process handles the exit value
> > properly and propagates the TBROK.
> > It is also strange that TBROK is the only return value that is solely
> > propagated by the exit value and not by the counters. This has been
> > mistake to begin with.
> Anybody to review this?
> I consider it important and at the same time quite safe to apply since
> I've tried to keep the changes minimal.
+1
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Kind regards,
Petr
next prev parent reply other threads:[~2020-12-08 13:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-27 16:31 [LTP] [PATCH 0/2] First step in formalizing the test library Cyril Hrubis
2020-11-27 16:31 ` [LTP] [PATCH 1/2] lib: tst_test.c: Add TBROK counter Cyril Hrubis
2020-12-03 12:16 ` Cyril Hrubis
2020-12-08 13:51 ` Petr Vorel [this message]
2020-12-09 14:08 ` Cyril Hrubis
2020-11-27 16:31 ` [LTP] [PATCH 2/2] lib: Add test library design document Cyril Hrubis
2020-12-01 7:42 ` Jan Stancek
2020-12-01 8:26 ` Cyril Hrubis
2020-12-01 9:07 ` [LTP] [PATCH v2 " Jan Stancek
2020-12-01 9:20 ` Cyril Hrubis
2020-12-01 10:47 ` Jan Stancek
2020-12-01 12:17 ` Cyril Hrubis
2020-12-01 11:38 ` Joerg Vehlow
2020-12-02 20:10 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X8+E5BMEOjuVIRen@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox