From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 3/5] syscalls/fanotify09: Read variable length events
Date: Tue, 8 Dec 2020 08:30:56 +0100 [thread overview]
Message-ID: <X88rsF3xHgtqzP3t@pevik> (raw)
In-Reply-To: <CAOQ4uxhWB6Gq2SinwbKJ=PmkO=EWtcvLoF71GDPit8V=B+17EQ@mail.gmail.com>
Hi Amir,
...
> > > The fix exists in the following patch, therefore I did not notice the
> > > mid series regression.
> > While this is valid to be added in this commit and I'll add it, it does not fix
> > our solution. I might not be clear: since this commit it's broken.
> > Thus any other tip?
> So both a mid series regression and full series regression.
> Lovely :)
> Following patch needs this fix:
> --- a/testcases/kernel/syscalls/fanotify/fanotify09.c
> +++ b/testcases/kernel/syscalls/fanotify/fanotify09.c
> @@ -280,6 +280,7 @@ static void test_fanotify(unsigned int n)
> event = (struct fanotify_event_metadata *)event_buf;
> verify_event(i, event, expect, "");
> + event = FAN_EVENT_NEXT(event, ret);
> for (; FAN_EVENT_OK(event, ret);
> FAN_EVENT_NEXT(event, ret)) {
> if (event->fd != FAN_NOFD)
> Pushed full fix series (including un-posted inotify test) to:
> https://github.com/amir73il/ltp/commits/fsnotify-fixes
Thanks! I was wrong, next commit was broken due missing this,
as you had correctly fixed in your LTP fork.
Anyway, merged!
Kind regards,
Petr
next prev parent reply other threads:[~2020-12-08 7:30 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-04 9:59 [LTP] [PATCH 0/5] Fanotify cleanup and test for v5.9 regression Amir Goldstein
2020-12-04 9:59 ` [LTP] [PATCH 1/5] syscalls/fanotify: Generalize check for FAN_REPORT_FID support Amir Goldstein
2020-12-04 13:52 ` Petr Vorel
2020-12-07 10:48 ` Jan Kara
2020-12-04 9:59 ` [LTP] [PATCH 2/5] syscalls/fanotify: Use generic checks for fanotify_init flags Amir Goldstein
2020-12-04 13:55 ` Petr Vorel
2020-12-07 10:52 ` Jan Kara
2020-12-04 9:59 ` [LTP] [PATCH 3/5] syscalls/fanotify09: Read variable length events Amir Goldstein
2020-12-04 14:16 ` Petr Vorel
2020-12-07 10:55 ` Jan Kara
2020-12-07 11:44 ` Petr Vorel
2020-12-07 11:57 ` Petr Vorel
2020-12-07 14:07 ` Amir Goldstein
2020-12-07 14:22 ` Petr Vorel
2020-12-07 16:17 ` Amir Goldstein
2020-12-08 7:30 ` Petr Vorel [this message]
2020-12-04 9:59 ` [LTP] [PATCH 4/5] syscalls/fanotify09: Add test case with two non-dir children Amir Goldstein
2020-12-04 14:19 ` Petr Vorel
2020-12-07 11:01 ` Jan Kara
2020-12-04 9:59 ` [LTP] [PATCH 5/5] syscalls/fanotify09: Add test case for events with filename info Amir Goldstein
2020-12-04 14:22 ` Petr Vorel
2020-12-07 11:11 ` Jan Kara
2020-12-04 14:27 ` [LTP] [PATCH 0/5] Fanotify cleanup and test for v5.9 regression Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X88rsF3xHgtqzP3t@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox