From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v5 04/10] fanotify: Add helper for FAN_REPORT_FID support on fs
Date: Fri, 4 Dec 2020 14:47:55 +0100 [thread overview]
Message-ID: <X8o+C0WZV8f8VONT@pevik> (raw)
In-Reply-To: <CAOQ4uxhdW2x=gUD1D39Pc3Ke3QmkDUZswcLuA4djH6jcQZP_=w@mail.gmail.com>
Hi Amir,
...
> > > Maybe this would be just easier to read as a macro:
> > > #define FANOTIFY_FAN_REPORT_FID_ERR_MSG(res_func, fail) do { \
> > > if (fail == -1) \
> > > res_func(TCONF, "FAN_REPORT_FID not supported in kernel?"); \
> > > if (fail == -2) \
> > > res_func(TCONF, ...); \
> > > } while (0)
> Sorry, I ended up reverting that back to a function.
np, probably better anyway.
...
> > > The rest is good.
> > Both your comments fixed, patchset merged.
> > Thank you both for your patient review,
> > Amir, I'm sorry it took me that long.
> No worries.
> I know there was a lot of black magic behind all the flag checks
> that needed explanations.
> > Looking forward to your patchset :).
> Posted.
Thanks!
> Note that I only tested upstream, v5.8, v4.20 and not kernels
> without permission events support and not exfat.
> I trust you will help to fill those testing gaps.
Sure! I should get into that early next week.
> If I am not mistaken, before my fixes, fanotify10 was going to fail
> instead of TCONF on exfat/ntfs and kernel >= v5.9, but I did not check.
Don't fail on master on my openSUSE kernel 5.10.0-rc5-2.ge84a0b5-default
> Thanks,
> Amir.
Kind regards,
Petr
next prev parent reply other threads:[~2020-12-04 13:47 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 17:42 [LTP] [PATCH v5 00/10] Introduce SAFE_FANOTIFY_MARK() macro + cleanup Petr Vorel
2020-12-01 17:42 ` [LTP] [PATCH v5 01/10] fanotify12: Drop incorrect hint Petr Vorel
2020-12-02 15:09 ` Cyril Hrubis
2020-12-01 17:42 ` [LTP] [PATCH v5 02/10] fanotify: Add helper for access permission check Petr Vorel
2020-12-02 15:24 ` Cyril Hrubis
2020-12-01 17:42 ` [LTP] [PATCH v5 03/10] fanotify: Add helper for event support check Petr Vorel
2020-12-02 15:36 ` Cyril Hrubis
2020-12-01 17:42 ` [LTP] [PATCH v5 04/10] fanotify: Add helper for FAN_REPORT_FID support on fs Petr Vorel
2020-12-02 15:46 ` Cyril Hrubis
2020-12-02 18:04 ` Petr Vorel
2020-12-04 10:11 ` Amir Goldstein
2020-12-04 13:47 ` Petr Vorel [this message]
2020-12-01 17:42 ` [LTP] [PATCH v5 05/10] fanotify16: Test also on FUSE Petr Vorel
2020-12-02 15:46 ` Cyril Hrubis
2020-12-01 17:42 ` [LTP] [PATCH v5 06/10] fanotify: Add helper for mark support check Petr Vorel
2020-12-02 6:27 ` Amir Goldstein
2020-12-02 15:57 ` Cyril Hrubis
2020-12-02 17:05 ` Petr Vorel
2020-12-02 15:53 ` Cyril Hrubis
2020-12-01 17:42 ` [LTP] [PATCH v5 07/10] fanotify: Introduce SAFE_FANOTIFY_MARK() macro Petr Vorel
2020-12-02 15:55 ` Cyril Hrubis
2020-12-02 15:58 ` Cyril Hrubis
2020-12-01 17:42 ` [LTP] [PATCH v5 08/10] fanotify: Use tst_brk_ in safe_fanotify_init() Petr Vorel
2020-12-02 15:55 ` Cyril Hrubis
2020-12-01 17:42 ` [LTP] [PATCH v5 09/10] fanotify: Add a pedantic check for return value Petr Vorel
2020-12-02 15:56 ` Cyril Hrubis
2020-12-01 17:42 ` [LTP] [PATCH] fanotify: Cleanup <sys/fanotify.h> use Petr Vorel
2020-12-02 16:12 ` Cyril Hrubis
2020-12-01 17:46 ` [LTP] [PATCH v5 00/10] Introduce SAFE_FANOTIFY_MARK() macro + cleanup Petr Vorel
2020-12-02 6:47 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X8o+C0WZV8f8VONT@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox