From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/1] if-mtu-change.sh: Add max packet size detection for IPv4
Date: Wed, 16 Dec 2020 15:45:03 +0100 [thread overview]
Message-ID: <X9odb308xDv/W+Ou@pevik> (raw)
In-Reply-To: <53607e8b-176f-5aaf-4b5f-9efabd1d756f@oracle.com>
Hi Alexey,
> Hi Petr,
> Another option would be to limit max size according to the size of
> the set mtu, so that we test packets with and without fragmentation,
> i.e. tst_ping -s "1 $((mtu / 2)) $mtu $((5 * mtu))", where "$mtu"
> size - for minor fragmentation.
Yes, that would fix the problem as well.
> Anyway the patch looks good, minor comments below.
I would prefer to also test higher MTU, thus I'll merge my patchset with all
changes you're suggested.
Thanks a lot for your review.
Kind regards,
Petr
next prev parent reply other threads:[~2020-12-16 14:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 19:05 [LTP] [PATCH 1/1] if-mtu-change.sh: Add max packet size detection for IPv4 Petr Vorel
2020-12-16 12:08 ` Alexey Kodanev
2020-12-16 14:45 ` Petr Vorel [this message]
2020-12-16 14:57 ` Petr Vorel
2021-01-04 6:53 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X9odb308xDv/W+Ou@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox