From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/1] Docparse: Escape | in table content
Date: Wed, 16 Dec 2020 17:02:25 +0100 [thread overview]
Message-ID: <X9ovkdN27zTsK+PN@pevik> (raw)
In-Reply-To: <X9ooMiuT3DKHwHjJ@yuki.lan>
> Hi!
> > BTW I wonder how to fix .test_variants in JSON:
> > "test_variants": "ARRAY_SIZE"
> > It's in many tests, e.g. testcases/kernel/syscalls/clock_gettime/clock_gettime02.c.
> I guess that we can filter out test_variants for now, I do not think
> that it will be useful for the metadata that much.
+1, I'll do it.
> > Also many arrays should be anonymous, e.g. exe_options (for .options) and
> > resource_files (for .resource_files) in testcases/kernel/syscalls/execve/execve05.c.
> > I wonder if there can be smarter solution before we fix it.
> Well either we teach the C parser about variables, or we move all the
> definitions inline. I would just move them since that's easier to do.
+1.
> > But using inline for .options (and other two dimensional array needs to be fixed
> > again in the parser: it now prints array reference: ARRAY(0x563186f58048)
> > (for testcases/kernel/syscalls/ioctl/ioctl01.c).
> That's a bug in the perl that produces the asciidoc, it's parsed just
> fine in the json:
Sure, I meant perl parser, which is actually formatter.
I'll try to send a patch soon.
> "ioctl01": {
> "needs_root": "1",
> "needs_tmpdir": "1",
> "options": [
> [
> "D:",
> "device",
> "-D <tty device> : for example, /dev/tty[0-9]"
> ]
> ],
> "fname": "testcases/kernel/syscalls/ioctl/ioctl01.c"
> },
> > Because this disables reusing things (putting them in the header). But you
> > probably prefer it than slower down parsing with preprocessor.
> > But we need to state this policy in docs.
> Indeed, that should be done.
Kind regards,
Petr
next prev parent reply other threads:[~2020-12-16 16:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-16 14:32 [LTP] [PATCH 1/1] Docparse: Escape | in table content Petr Vorel
2020-12-16 14:42 ` Cyril Hrubis
2020-12-16 15:10 ` Petr Vorel
2020-12-16 15:30 ` Cyril Hrubis
2020-12-16 16:02 ` Petr Vorel [this message]
2020-12-16 19:15 ` Petr Vorel
2020-12-16 21:14 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X9ovkdN27zTsK+PN@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox