public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 2/2] docparse/parse.sh: Fix running with relative path
Date: Thu, 17 Dec 2020 13:22:31 +0100	[thread overview]
Message-ID: <X9tNhwYzPyXpOEfx@yuki.lan> (raw)
In-Reply-To: <20201217121520.25713-3-pvorel@suse.cz>

Hi!
> that's not needed for build, but useful for debugging.
> 
> Running as ./parse.sh fails:
> cat: ./../VERSION: No such file or directory
> 
> top_srcdir must be absolute path.
> 
> Fixes: a069cd36b ("docparse: Add test documentation parser")
> 
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
>  docparse/parse.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/docparse/parse.sh b/docparse/parse.sh
> index 172eab702..79011bc10 100755
> --- a/docparse/parse.sh
> +++ b/docparse/parse.sh
> @@ -5,7 +5,7 @@
>  set -e
>  
>  top_builddir=$PWD/..
> -top_srcdir="$(dirname $0)/.."
> +top_srcdir="$(cd $(dirname $0)/..; pwd)"
>  
>  cd $top_srcdir

Reviewed-by: Cyril Hrubis <chrubis@suse.cz>

-- 
Cyril Hrubis
chrubis@suse.cz

      reply	other threads:[~2020-12-17 12:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-17 12:15 [LTP] [PATCH 0/2] Travis build fixes Petr Vorel
2020-12-17 12:15 ` [LTP] [PATCH 1/2] docparse/parse.sh: Fix parsing on dash Petr Vorel
2020-12-17 12:20   ` Cyril Hrubis
2020-12-17 12:36     ` Petr Vorel
2020-12-17 12:58     ` Petr Vorel
2020-12-17 12:15 ` [LTP] [PATCH 2/2] docparse/parse.sh: Fix running with relative path Petr Vorel
2020-12-17 12:22   ` Cyril Hrubis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=X9tNhwYzPyXpOEfx@yuki.lan \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox