From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0DEB4C05027 for ; Fri, 17 Feb 2023 11:35:16 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 2E56B3CBE84 for ; Fri, 17 Feb 2023 12:35:14 +0100 (CET) Received: from in-5.smtp.seeweb.it (in-5.smtp.seeweb.it [217.194.8.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 7D2B13CB190 for ; Fri, 17 Feb 2023 12:35:04 +0100 (CET) Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-5.smtp.seeweb.it (Postfix) with ESMTPS id 06B16600485 for ; Fri, 17 Feb 2023 12:35:03 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C67DD338BC; Fri, 17 Feb 2023 11:35:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1676633702; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DKQ3Pi/dtsveenq6fn7HKE7TDgzlekLo7Plrz+ARrZA=; b=kt55o8tqJ0PCdkVMkl0HKNwuQYTp6AJhvZ3GPuhjW/cRuqmQN/wttwhNeRhJpY1Qmh4n9/ wYT9+L7FY/v75LaZLtqTGwwNkj2pBJn7R60ChmweWaK1y+jwRBl5J6/BsTnB737pfcRhYT Z38hBOnwkuJwDqlzbP3psf/sWYRH1uw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1676633702; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DKQ3Pi/dtsveenq6fn7HKE7TDgzlekLo7Plrz+ARrZA=; b=/S7j4L4yqHtLmsxltKQIO0NDREqburp/0y3vMajigfvI5AUa8pz2liktuoIcySDoOkR/lS TcneTxa4+9riZuAg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A13D0138E3; Fri, 17 Feb 2023 11:35:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id N985JmZm72PJTQAAMHmgww (envelope-from ); Fri, 17 Feb 2023 11:35:02 +0000 Date: Fri, 17 Feb 2023 12:34:55 +0100 From: Petr Vorel To: ltp@lists.linux.it Message-ID: References: <20230126215401.29101-1-pvorel@suse.cz> <20230126215401.29101-10-pvorel@suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230126215401.29101-10-pvorel@suse.cz> X-Virus-Scanned: clamav-milter 0.102.4 at in-5.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH 9/9] tst_net.sh: Move net setup into separate function X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi all, > Having network setup in separate function helps readability. > Test environment variables are for readability kept outside. FYI I rebased this (removed new functions) and merged. Kind regards, Petr -- Mailing list info: https://lists.linux.it/listinfo/ltp