From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 6/9] tst_net.sh: Rename function + add doc
Date: Fri, 17 Feb 2023 13:28:38 +0100 [thread overview]
Message-ID: <Y+9y9nRhi23wQf/Q@pevik> (raw)
In-Reply-To: <Y+OsQt/ReLv1pt5R@yuki>
Hi Cyril,
...
> Ah, it's more complicated than a single switch, there is actually a
> master swtich, default settings and per interface settings.
> i.e. /proc/sys/net/ipv6/conf/default/disable_ipv6
> /proc/sys/net/ipv6/conf/all/disable_ipv6
> /proc/sys/net/ipv6/conf/${IFACE}/disable_ipv6
> Since the deafult value is I suppose inherited by newly added interfaces
> we have to check if ipv6 is disabled by sysctl in the case of network
> namespaces as well, right? Technically we could probably check the
> default/disable_ipv6 before we attempt to create new interfaces, but I
> guess that we woudl rather want to have the same code both for ssh and
> namespaces.
In the end I decided to add check for net.ipv6.conf.all.disable_ipv6=1 in
tst_init_iface() (calls ip link set ...). This way it should be tested only when
needed. That means we need 2 functions.
I wonder if it still makes sense to check net.ipv6.conf.$iface.disable_ipv6
(IMHO needed for two host based setup with IPv6 non-friendly configuration).
I'd be for this check, but it could be in function which checks cmdline.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2023-02-17 12:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 21:53 [LTP] [PATCH 0/9] tst_net.sh fixes + cleanup Petr Vorel
2023-01-26 21:53 ` [LTP] [PATCH 1/9] tst_net.sh: Use tst_res_() Petr Vorel
2023-02-01 11:08 ` Petr Vorel
2023-01-26 21:53 ` [LTP] [PATCH 2/9] tst_net.sh: Check for disabled IPv6 in legacy tests Petr Vorel
2023-02-01 10:49 ` Petr Vorel
2023-01-26 21:53 ` [LTP] [PATCH 3/9] tst_net.sh: Remove unneeded $_tst_net_parse_variables Petr Vorel
2023-01-26 21:53 ` [LTP] [PATCH 4/9] tst_net.sh: Remove unneeded $TST_INIT_NETNS variable Petr Vorel
2023-01-26 21:53 ` [LTP] [PATCH 5/9] tst_net.sh: Add more tst_require_cmds check Petr Vorel
2023-02-01 11:39 ` Petr Vorel
2023-01-26 21:53 ` [LTP] [PATCH 6/9] tst_net.sh: Rename function + add doc Petr Vorel
2023-02-08 10:18 ` Cyril Hrubis
2023-02-08 13:45 ` Petr Vorel
2023-02-08 14:05 ` Cyril Hrubis
2023-02-08 14:50 ` Petr Vorel
2023-02-17 12:28 ` Petr Vorel [this message]
2023-01-26 21:53 ` [LTP] [PATCH 7/9] tst_net.sh: Remove unused variable ret Petr Vorel
2023-01-26 21:54 ` [LTP] [PATCH 8/9] tst_net.sh: Harden on disabled IPv6 via sysctl Petr Vorel
2023-01-26 21:54 ` [LTP] [PATCH 9/9] tst_net.sh: Move net setup into separate function Petr Vorel
2023-02-17 11:34 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+9y9nRhi23wQf/Q@pevik \
--to=pvorel@suse.cz \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox