From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BA7C9C61DA4 for ; Mon, 6 Feb 2023 06:12:25 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 0CBE23CB182 for ; Mon, 6 Feb 2023 07:12:24 +0100 (CET) Received: from in-5.smtp.seeweb.it (in-5.smtp.seeweb.it [217.194.8.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 3AFBC3C2A67 for ; Mon, 6 Feb 2023 07:12:15 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-5.smtp.seeweb.it (Postfix) with ESMTPS id 903A86006E0 for ; Mon, 6 Feb 2023 07:12:14 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id BDCC260268; Mon, 6 Feb 2023 06:12:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1675663933; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1hkdGMtPTUMKke3lUZge79fbgjMehqVPgQVfKiLEiJQ=; b=OU3HlZRCSjiqUxGFoaLEYlqVHrxZ7L6uwIxagAPPIQkRRQvSz+Z6xnn7+kGi6PQOKfDBMe 9dBNds2wC3NhpUfJ23VEoNXgFm8zqwGY2zANzy7RLHGMVJWUtWW1WnIIDgTJ0iApZ4Ecfd yXZFfy7xbDEAAaVVc91dSJAkipSMnPI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1675663933; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1hkdGMtPTUMKke3lUZge79fbgjMehqVPgQVfKiLEiJQ=; b=1KRJ2mk/Ni1F3ekfXhf5aAdnVmp0/jn9NjeLjvF9sGgyDLg195zliYdze1cc2KXVWT0kas +HmiLz3S06PEt+BA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 935B01390C; Mon, 6 Feb 2023 06:12:13 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 40TUIj2a4GOeNgAAMHmgww (envelope-from ); Mon, 06 Feb 2023 06:12:13 +0000 Date: Mon, 6 Feb 2023 07:12:11 +0100 From: Petr Vorel To: Wei Gao , ltp@lists.linux.it Message-ID: References: <20230129183930.2045-1-wegao@suse.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Virus-Scanned: clamav-milter 0.102.4 at in-5.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v1] ioctl01.c:Test also struct termios X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi Wei, > Hi Wei, ... > > @@ -64,7 +66,21 @@ static void verify_ioctl(unsigned int i) > > if (TST_ERR != tcases[i].error) { > > tst_res(TFAIL | TTERRNO, > > "failed unexpectedly; expected %s", > > - tst_strerrno(tcases[i].error)); > > + tst_strerrno(tcases[i].error)); > > + return; > > + } > Could you please replace TEST(ioctl(...) with TST_EXP_FAIL(ioctl(...))? > That would save all error handling. > We try to use these helping macros in include/tst_test_macros.h. > Although they would deserve some docs as macros are a bit harder to read. I implemented this in 4c86809f77 ("ioctl01: cleanup"). Could you please rebase your commit and use TST_EXP_FAIL() in it? Thank you! Kind regards, Petr -- Mailing list info: https://lists.linux.it/listinfo/ltp