* [LTP] [PATCH 1/1] lib: Allow zero iterations (-i0)
@ 2023-02-06 6:10 Petr Vorel
2023-02-06 10:36 ` Avinesh Kumar
2023-02-06 14:17 ` Jan Stancek
0 siblings, 2 replies; 4+ messages in thread
From: Petr Vorel @ 2023-02-06 6:10 UTC (permalink / raw)
To: ltp
-i0 is helpful to test if setup and cleanup are working.
We suggest that in maintainer-patch-review-checklist.txt.
Fixes: 4c0465f217 ("lib: Replace atoi/atof with SAFE_STRTOL/SAFE_STRTOF")
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
lib/tst_test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/tst_test.c b/lib/tst_test.c
index 23d21c8255..04d6b13bfc 100644
--- a/lib/tst_test.c
+++ b/lib/tst_test.c
@@ -678,7 +678,7 @@ static void parse_opts(int argc, char *argv[])
print_test_tags();
exit(0);
case 'i':
- iterations = SAFE_STRTOL(optarg, 1, INT_MAX);
+ iterations = SAFE_STRTOL(optarg, 0, INT_MAX);
break;
case 'I':
if (tst_test->max_runtime > 0)
--
2.39.1
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [LTP] [PATCH 1/1] lib: Allow zero iterations (-i0)
2023-02-06 6:10 [LTP] [PATCH 1/1] lib: Allow zero iterations (-i0) Petr Vorel
@ 2023-02-06 10:36 ` Avinesh Kumar
2023-02-06 14:17 ` Jan Stancek
1 sibling, 0 replies; 4+ messages in thread
From: Avinesh Kumar @ 2023-02-06 10:36 UTC (permalink / raw)
To: Petr Vorel; +Cc: ltp
Hi,
Reviewed-by: Avinesh Kumar <akumar@suse.de>
On Monday, February 6, 2023 11:40:01 AM IST Petr Vorel wrote:
> -i0 is helpful to test if setup and cleanup are working.
> We suggest that in maintainer-patch-review-checklist.txt.
>
> Fixes: 4c0465f217 ("lib: Replace atoi/atof with SAFE_STRTOL/SAFE_STRTOF")
>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> lib/tst_test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/tst_test.c b/lib/tst_test.c
> index 23d21c8255..04d6b13bfc 100644
> --- a/lib/tst_test.c
> +++ b/lib/tst_test.c
> @@ -678,7 +678,7 @@ static void parse_opts(int argc, char *argv[])
> print_test_tags();
> exit(0);
> case 'i':
> - iterations = SAFE_STRTOL(optarg, 1, INT_MAX);
> + iterations = SAFE_STRTOL(optarg, 0, INT_MAX);
> break;
> case 'I':
> if (tst_test->max_runtime > 0)
>
Regards,
Avinesh
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [LTP] [PATCH 1/1] lib: Allow zero iterations (-i0)
2023-02-06 6:10 [LTP] [PATCH 1/1] lib: Allow zero iterations (-i0) Petr Vorel
2023-02-06 10:36 ` Avinesh Kumar
@ 2023-02-06 14:17 ` Jan Stancek
2023-02-06 16:12 ` Petr Vorel
1 sibling, 1 reply; 4+ messages in thread
From: Jan Stancek @ 2023-02-06 14:17 UTC (permalink / raw)
To: Petr Vorel; +Cc: ltp
On Mon, Feb 6, 2023 at 7:10 AM Petr Vorel <pvorel@suse.cz> wrote:
>
> -i0 is helpful to test if setup and cleanup are working.
> We suggest that in maintainer-patch-review-checklist.txt.
Until now, I never thought of trying -i0 :-)
Acked-by: Jan Stancek <jstancek@redhat.com>
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-02-06 16:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-06 6:10 [LTP] [PATCH 1/1] lib: Allow zero iterations (-i0) Petr Vorel
2023-02-06 10:36 ` Avinesh Kumar
2023-02-06 14:17 ` Jan Stancek
2023-02-06 16:12 ` Petr Vorel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox