From: Petr Vorel <pvorel@suse.cz>
To: Tarun Sahu <tsahu@linux.ibm.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] hugepage15: Resolve compile time warning generating with -O0
Date: Sun, 12 Feb 2023 22:34:44 +0100 [thread overview]
Message-ID: <Y+lbdJfWRVW7rPNw@pevik> (raw)
In-Reply-To: <20230210223342.240969-1-tsahu@linux.ibm.com>
Hi Tarun,
> Instead of turning off the optimizaton with -O0 to resolve unwanted
> behaviour of clang with goto statements, this will make use of clang
> pragma to turn off the optimization for just clang compiler. This way,
> gcc won't throw unwanted warning on turning off optimization:
> "warning: _FORTIFY_SOURCE requires compiling with optimization (-O)".
Thanks!
Reviewed-by: Petr Vorel <petr.vorel@gmail.com>
> Also, removed redundant header-includes.
BTW this does not apply because there was change which is not in your fork:
1106777cd ("hugemmap15: Use TST_TEST_TCONF() for unsupported archs")
No need to repost, but please always rebase to current master before posting
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2023-02-12 21:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-25 22:27 [LTP] [PATCH 0/2] hugemmap15 pre-release testing Petr Vorel
2023-01-25 22:27 ` [LTP] [PATCH 1/2] hugemmap15: Compile with -O Petr Vorel
2023-01-26 21:05 ` Tarun Sahu
2023-01-26 23:00 ` Petr Vorel
2023-01-26 23:38 ` Tarun Sahu
2023-01-27 8:28 ` Petr Vorel
2023-01-27 9:20 ` Cyril Hrubis
2023-02-10 22:04 ` Tarun Sahu
2023-02-10 22:33 ` [LTP] [PATCH] hugepage15: Resolve compile time warning generating with -O0 Tarun Sahu
2023-02-12 21:34 ` Petr Vorel [this message]
2023-02-13 15:29 ` Tarun Sahu
2023-02-13 15:26 ` [LTP] [PATCH v2] " Tarun Sahu
2023-02-13 17:26 ` Petr Vorel
2023-01-25 22:27 ` [LTP] [PATCH 2/2] hugemmap15.c: Use TST_TEST_TCONF() for unsupported archs Petr Vorel
2023-01-26 10:35 ` Cyril Hrubis
2023-01-26 10:36 ` Petr Vorel
2023-01-26 17:55 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+lbdJfWRVW7rPNw@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
--cc=tsahu@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox