From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 94A3EC61DA4 for ; Tue, 14 Feb 2023 12:06:02 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 091263CC5B7 for ; Tue, 14 Feb 2023 13:06:00 +0100 (CET) Received: from in-3.smtp.seeweb.it (in-3.smtp.seeweb.it [IPv6:2001:4b78:1:20::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id CF77F3C1D84 for ; Tue, 14 Feb 2023 13:05:45 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-3.smtp.seeweb.it (Postfix) with ESMTPS id 412DE1A00807 for ; Tue, 14 Feb 2023 13:05:44 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 32F2A1F383; Tue, 14 Feb 2023 12:05:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1676376344; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=O5TDemRf2SUiAoPME0GRRG1fyA2XKElbOzOl7uPbk7M=; b=wnJvIL/l0NN/5UMg236bZDpjsWuZAFRLE1m3wHzqKqNsVzpx7iRG5qO4JjntAfvFbbb+Om pYStAT8mVmt4Ks7HMKbO6cNBb01RxvSvMQDOS+sZmnPbIKrz6uPdC7521tLuRsJXASF4va O8g0v5HsJe0RVkMfD5rTcF19UW6g66w= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1676376344; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=O5TDemRf2SUiAoPME0GRRG1fyA2XKElbOzOl7uPbk7M=; b=tsTE8qr2s4rc/PPUExCievKP1B6J/wv81QYMAl0ryCnWdljmXJnWzpHlX791RjHBS5E3hp EMaJIbkf8GXUl+Ag== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1A55113A21; Tue, 14 Feb 2023 12:05:44 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id uiLPBRh562OfDgAAMHmgww (envelope-from ); Tue, 14 Feb 2023 12:05:44 +0000 Date: Tue, 14 Feb 2023 13:07:10 +0100 From: Cyril Hrubis To: Andrea Cervesato Message-ID: References: <20230208091120.9994-1-andrea.cervesato@suse.com> <5be1311a-6057-5362-93f6-ee623279e79e@suse.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5be1311a-6057-5362-93f6-ee623279e79e@suse.com> X-Virus-Scanned: clamav-milter 0.102.4 at in-3.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v4] Refactor pidns30 test using new LTP API X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > >> +static void run(void) > >> { > >> - int status; > >> - char buf[5]; > >> - pid_t cpid; > >> + const struct tst_clone_args args = { CLONE_NEWPID, SIGCHLD }; > >> > >> - setup(); > >> + remove_mqueue(mqd); > >> + received = 0; > > I wonder if we really need to clear the flag here, as far as I can see > > we only modify that variable in the child process and that shouldn't > > propagate to parent, unless we pass CLONE_VM of course. > Flag reset has been added to be 100% sure we are receiving the signal on > -i > 1. My point was that the variable is only changed in the child process, that means that this change will never make it back to the parent since the whole VM is copy-on-write... -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp