public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
* [LTP] [PATCH] syscalls/creat09: Add reference to CVE 2021-4037
@ 2022-10-05 13:15 Martin Doucha
  2022-10-06  5:16 ` Petr Vorel
  0 siblings, 1 reply; 4+ messages in thread
From: Martin Doucha @ 2022-10-05 13:15 UTC (permalink / raw)
  To: ltp

Signed-off-by: Martin Doucha <mdoucha@suse.cz>
---
 testcases/kernel/syscalls/creat/creat09.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/testcases/kernel/syscalls/creat/creat09.c b/testcases/kernel/syscalls/creat/creat09.c
index 620408920..a5d3740ac 100644
--- a/testcases/kernel/syscalls/creat/creat09.c
+++ b/testcases/kernel/syscalls/creat/creat09.c
@@ -155,6 +155,7 @@ static struct tst_test test = {
 	.tags = (const struct tst_tag[]) {
 		{"linux-git", "0fa3ecd87848"},
 		{"CVE", "2018-13405"},
+		{"CVE", "2021-4037"},
 		{"linux-git", "01ea173e103e"},
 		{"linux-git", "1639a49ccdce"},
 		{"linux-git", "426b4ca2d6a5"},
-- 
2.37.3


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [LTP] [PATCH] syscalls/creat09: Add reference to CVE 2021-4037
  2022-10-05 13:15 [LTP] [PATCH] syscalls/creat09: Add reference to CVE 2021-4037 Martin Doucha
@ 2022-10-06  5:16 ` Petr Vorel
  2022-10-06  8:27   ` Martin Doucha
  0 siblings, 1 reply; 4+ messages in thread
From: Petr Vorel @ 2022-10-06  5:16 UTC (permalink / raw)
  To: Martin Doucha; +Cc: ltp

Hi Martin,

thx, merged!

> +++ b/testcases/kernel/syscalls/creat/creat09.c
> @@ -155,6 +155,7 @@ static struct tst_test test = {
>  	.tags = (const struct tst_tag[]) {
>  		{"linux-git", "0fa3ecd87848"},
>  		{"CVE", "2018-13405"},
> +		{"CVE", "2021-4037"},

How about this change:

diff --git runtest/cve runtest/cve
index 9ab6dc282..6ad3f51fb 100644
--- runtest/cve
+++ runtest/cve
@@ -55,7 +55,7 @@ cve-2018-1000001 realpath01
 cve-2018-1000199 ptrace08
 cve-2018-1000204 ioctl_sg01
 cve-2018-12896 timer_settime03
-cve-2018-13405 creat09
+cve-2018-13405-cve-2021-4037 creat09
 cve-2018-18445 bpf_prog04
 cve-2018-18559 bind06
 cve-2018-18955 userns08

Kind regards,
Petr

>  		{"linux-git", "01ea173e103e"},
>  		{"linux-git", "1639a49ccdce"},
>  		{"linux-git", "426b4ca2d6a5"},

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [LTP] [PATCH] syscalls/creat09: Add reference to CVE 2021-4037
  2022-10-06  5:16 ` Petr Vorel
@ 2022-10-06  8:27   ` Martin Doucha
  2022-10-07 21:19     ` Petr Vorel
  0 siblings, 1 reply; 4+ messages in thread
From: Martin Doucha @ 2022-10-06  8:27 UTC (permalink / raw)
  To: Petr Vorel; +Cc: ltp

On 06. 10. 22 7:16, Petr Vorel wrote:
> How about this change:
> 
> diff --git runtest/cve runtest/cve
> index 9ab6dc282..6ad3f51fb 100644
> --- runtest/cve
> +++ runtest/cve
> @@ -55,7 +55,7 @@ cve-2018-1000001 realpath01
>   cve-2018-1000199 ptrace08
>   cve-2018-1000204 ioctl_sg01
>   cve-2018-12896 timer_settime03
> -cve-2018-13405 creat09
> +cve-2018-13405-cve-2021-4037 creat09
>   cve-2018-18445 bpf_prog04
>   cve-2018-18559 bind06
>   cve-2018-18955 userns08

I don't think we need to complicate the runfile name like this. As long 
as the CVE reference gets printed on failure and can be found via 
grepping the sources, it's good enough.

-- 
Martin Doucha   mdoucha@suse.cz
QA Engineer for Software Maintenance
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [LTP] [PATCH] syscalls/creat09: Add reference to CVE 2021-4037
  2022-10-06  8:27   ` Martin Doucha
@ 2022-10-07 21:19     ` Petr Vorel
  0 siblings, 0 replies; 4+ messages in thread
From: Petr Vorel @ 2022-10-07 21:19 UTC (permalink / raw)
  To: Martin Doucha; +Cc: ltp

> On 06. 10. 22 7:16, Petr Vorel wrote:
> > How about this change:

> > diff --git runtest/cve runtest/cve
> > index 9ab6dc282..6ad3f51fb 100644
> > --- runtest/cve
> > +++ runtest/cve
> > @@ -55,7 +55,7 @@ cve-2018-1000001 realpath01
> >   cve-2018-1000199 ptrace08
> >   cve-2018-1000204 ioctl_sg01
> >   cve-2018-12896 timer_settime03
> > -cve-2018-13405 creat09
> > +cve-2018-13405-cve-2021-4037 creat09
> >   cve-2018-18445 bpf_prog04
> >   cve-2018-18559 bind06
> >   cve-2018-18955 userns08

> I don't think we need to complicate the runfile name like this. As long as
> the CVE reference gets printed on failure and can be found via grepping the
> sources, it's good enough.

You're right, the original CVE is probably enough.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-10-07 21:19 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-05 13:15 [LTP] [PATCH] syscalls/creat09: Add reference to CVE 2021-4037 Martin Doucha
2022-10-06  5:16 ` Petr Vorel
2022-10-06  8:27   ` Martin Doucha
2022-10-07 21:19     ` Petr Vorel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox