[LTP] [PATCH] syscalls/ioctl03: add IFF_NO_CARRIER feature flag

[LTP] [PATCH] syscalls/ioctl03: add IFF_NO_CARRIER feature flag

[Jan Stancek]

commit 195624d9c26b ("tun: support not enabling carrier in TUNSETIFF")
introduced IFF_NO_CARRIER feature flag. Add it to known flags
to avoid triggering:
  ioctl03.c:85: TFAIL: (UNKNOWN 0x40)

Signed-off-by: Jan Stancek <jstancek@redhat.com>
---
 testcases/kernel/syscalls/ioctl/ioctl03.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/testcases/kernel/syscalls/ioctl/ioctl03.c b/testcases/kernel/syscalls/ioctl/ioctl03.c
index 3d4ac3e240ad..d46c60787644 100644
--- a/testcases/kernel/syscalls/ioctl/ioctl03.c
+++ b/testcases/kernel/syscalls/ioctl/ioctl03.c
@@ -40,6 +40,11 @@
 #define IFF_NAPI_FRAGS	0x0020
 #endif
 
+#ifndef IFF_NO_CARRIER
+#define IFF_NO_CARRIER	0x0040
+#endif
+
+
 static struct {
 	unsigned int flag;
 	const char *name;
@@ -51,7 +56,8 @@ static struct {
 	{IFF_VNET_HDR, "VNET_HDR"},
 	{IFF_MULTI_QUEUE, "MULTI_QUEUE"},
 	{IFF_NAPI, "IFF_NAPI"},
-	{IFF_NAPI_FRAGS, "IFF_NAPI_FRAGS"}
+	{IFF_NAPI_FRAGS, "IFF_NAPI_FRAGS"},
+	{IFF_NO_CARRIER, "IFF_NO_CARRIER"},
 };
 
 static void verify_features(void)
-- 
2.27.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] syscalls/ioctl03: add IFF_NO_CARRIER feature flag

[Cyril Hrubis]

Hi!
> commit 195624d9c26b ("tun: support not enabling carrier in TUNSETIFF")
> introduced IFF_NO_CARRIER feature flag. Add it to known flags
> to avoid triggering:
>   ioctl03.c:85: TFAIL: (UNKNOWN 0x40)

Reviewed-by: Cyril Hrubis <chrubis@suse.cz>

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] syscalls/ioctl03: add IFF_NO_CARRIER feature flag

[Petr Vorel]

Hi Jan,

thanks for fixing this. Sven was faster [1], thus merged his commit
with also your Signed-off-by:

Kind regards,
Petr

[1] https://lore.kernel.org/ltp/20221007105727.2303349-1-svens@linux.ibm.com/

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] syscalls/ioctl03: add IFF_NO_CARRIER feature flag

[Jan Stancek]

On Mon, Oct 10, 2022 at 2:53 PM Petr Vorel <pvorel@suse.cz> wrote:
>
> Hi Jan,
>
> thanks for fixing this. Sven was faster [1], thus merged his commit
> with also your Signed-off-by:

Thanks Petr, I haven't seen his email - I received it only hour ago to
my mailbox.


>
> Kind regards,
> Petr
>
> [1] https://lore.kernel.org/ltp/20221007105727.2303349-1-svens@linux.ibm.com/
>


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] syscalls/ioctl03: add IFF_NO_CARRIER feature flag

[Petr Vorel]

> On Mon, Oct 10, 2022 at 2:53 PM Petr Vorel <pvorel@suse.cz> wrote:

> > Hi Jan,

> > thanks for fixing this. Sven was faster [1], thus merged his commit
> > with also your Signed-off-by:

> Thanks Petr, I haven't seen his email - I received it only hour ago to
> my mailbox.

I'm sorry, I didn't know it was in ML quarantine (Cyril noticed).
Anyway, thank you.

@Sven it's not a good idea to post to ML without being subscribed,
please subscribe next time before posting.

Kind regards,
Petr


> > Kind regards,
> > Petr

> > [1] https://lore.kernel.org/ltp/20221007105727.2303349-1-svens@linux.ibm.com/



-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] syscalls/ioctl03: add IFF_NO_CARRIER feature flag

[Cyril Hrubis]

Hi!
> @Sven it's not a good idea to post to ML without being subscribed,
> please subscribe next time before posting.

I've added him to allowed filter, I do that automatically for all email
addresses that send patches. But that still means that first post to the
ML will be delayed by a day or so until we get to review the queue.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp