From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 134F1C433FE for ; Mon, 10 Oct 2022 14:41:00 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 34C563CAE6E for ; Mon, 10 Oct 2022 16:40:58 +0200 (CEST) Received: from in-4.smtp.seeweb.it (in-4.smtp.seeweb.it [217.194.8.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id E7A9A3CAE54 for ; Mon, 10 Oct 2022 16:40:48 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-4.smtp.seeweb.it (Postfix) with ESMTPS id C8C4E1000374 for ; Mon, 10 Oct 2022 16:40:47 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 90D6E219C7; Mon, 10 Oct 2022 14:40:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1665412846; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=j7AIXaJQFOQh7omPOagH6nGRUMkLdt3RDcg9CXw9ik8=; b=gNjXBGOmwenCvkvJjeEcYFu6/oS/NVKEztzr3MZflsvMk8WVerfT+gXBfglKXP9vsv/78V 04VWJCnxvPpWJOG7Xwgi3Oj8GmyN2rdp91/y0Nr9vpXGhpLkB18kRWSbKbCNZzeal1DL+x CXi1FJHdUANq9l4sVIZBxyJNDJZ65D8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1665412846; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=j7AIXaJQFOQh7omPOagH6nGRUMkLdt3RDcg9CXw9ik8=; b=qskf/4xSa32VhQ+byzaZ9VgD3t37JsRmfG52oA3Ai6asETe6QqB8DHUQfgnwoJbOWvsGbt 1pioZlPYCa4YAqDw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5052813479; Mon, 10 Oct 2022 14:40:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id qPhVEe4uRGPoIQAAMHmgww (envelope-from ); Mon, 10 Oct 2022 14:40:46 +0000 Date: Mon, 10 Oct 2022 16:40:44 +0200 From: Petr Vorel To: Richard Palethorpe Message-ID: References: <1657608229-6189-1-git-send-email-zhanghongchen@loongson.cn> <871qrfak22.fsf@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <871qrfak22.fsf@suse.de> X-Virus-Scanned: clamav-milter 0.102.4 at in-4.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v2] rpc01: fix variable not initialized X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: ltp@lists.linux.it, Steve Dickson , libtirpc-devel@lists.sourceforge.net, Hongchen Zhang Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi Richie, > Hello, > Looks OK to me, Petr? > Acked-by: Richard Palethorpe I replied at ML at v1 [1] with a question to use rc for verification. I'm not sure whether it was me who marked the question as superseded. @Hongchen you sent v1 twice, v2 twice. Duplicate send without your reply does not speedup things. Please next time reply with ping (but if you don't reply to the question, ball is on your side). Kind regards, Petr [1] https://lore.kernel.org/ltp/Ysu+mbkO8eUP4A2+@pevik/ [2] https://patchwork.ozlabs.org/project/ltp/list/?submitter=84160&state=* > Hongchen Zhang writes: > > when error occurred in function callrpc/clnt_call, return_buffer may > > be leaved not initialized. > > As Petr said, we should check the return value before retrieve the > > return_buffer->data. Change do_compare's parameter from char * to > > struct data * to fix it. > > Signed-off-by: Hongchen Zhang > > --- > > testcases/network/rpc/basic_tests/rpc01/rpc1.c | 14 ++++++++------ > > 1 file changed, 8 insertions(+), 6 deletions(-) > > diff --git a/testcases/network/rpc/basic_tests/rpc01/rpc1.c b/testcases/network/rpc/basic_tests/rpc01/rpc1.c > > index bc9f35b..6b8619d 100644 > > --- a/testcases/network/rpc/basic_tests/rpc01/rpc1.c > > +++ b/testcases/network/rpc/basic_tests/rpc01/rpc1.c > > @@ -18,7 +18,8 @@ char *file_name = NULL; > > char host_name[100]; > > long host_address; > > -void do_compare(int, char *, struct data *, char *); > > +void do_compare(int rpc_rc, char *msg, struct data *buffer, > > + struct data *ret_buffer) > > void usage_error(char *program_name); > > int main(int argc, char *argv[]) > > @@ -128,7 +129,7 @@ int main(int argc, char *argv[]) > > rc = callrpc(server, program, version, 1, (xdrproc_t)xdr_send_data, > > (char *)&buffer, (xdrproc_t)xdr_receive_data, > > (char *)&return_buffer); > > - do_compare(rc, "callrpc", &buffer, return_buffer->data); > > + do_compare(rc, "callrpc", &buffer, return_buffer); > > server_sin.sin_port = 0; > > sock = RPC_ANYSOCK; > > @@ -145,7 +146,7 @@ int main(int argc, char *argv[]) > > (char *)&buffer, (xdrproc_t)xdr_receive_data, > > (char *)&return_buffer, timeout); > > clnt_destroy(clnt); > > - do_compare(rc, "udp transport", &buffer, return_buffer->data); > > + do_compare(rc, "udp transport", &buffer, return_buffer); > > server_sin.sin_port = 0; > > sock = RPC_ANYSOCK; > > @@ -160,12 +161,13 @@ int main(int argc, char *argv[]) > > (char *)&buffer, (xdrproc_t)xdr_receive_data, > > (char *)&return_buffer, timeout); > > clnt_destroy(clnt); > > - do_compare(rc, "tcp transport", &buffer, return_buffer->data); > > + do_compare(rc, "tcp transport", &buffer, return_buffer); > > exit(0); > > } > > -void do_compare(int rpc_rc, char *msg, struct data *buffer, char *ret_data) > > +void do_compare(int rpc_rc, char *msg, struct data *buffer, > > + struct data *ret_buffer) > > { > > int rc; > > @@ -175,7 +177,7 @@ void do_compare(int rpc_rc, char *msg, struct data *buffer, char *ret_data) > > printf("\n"); > > exit(1); > > } > > - rc = memcmp(buffer->data, ret_data, buffer->data_length); > > + rc = memcmp(buffer->data, ret_buffer->data, buffer->data_length); > > if (rc) { > > printf("Data compare for %s returned %d\n", msg, rc); > > exit(1); > > -- > > 1.8.3.1 -- Mailing list info: https://lists.linux.it/listinfo/ltp