From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2ACDFA3741 for ; Mon, 31 Oct 2022 14:56:35 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 2B0D23CAC01 for ; Mon, 31 Oct 2022 15:56:34 +0100 (CET) Received: from in-3.smtp.seeweb.it (in-3.smtp.seeweb.it [IPv6:2001:4b78:1:20::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 8ADB03C2A0E for ; Mon, 31 Oct 2022 15:56:24 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-3.smtp.seeweb.it (Postfix) with ESMTPS id 1FE8F1A007EB for ; Mon, 31 Oct 2022 15:56:23 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 744EA1F8BF; Mon, 31 Oct 2022 14:56:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1667228183; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xy2BFdtSMQu7+3yFdGMbRqBNhoao+VbAi0A7xJCvAI8=; b=3I8Y4KarTTs4tme1unBSS9iWKo7afNxzoo8c8Vk1j2cCyUu2GrV6VRIq57vzBZopJ0ZJ2w ss39rk6mVrvtB2xXfzmyfKHbV0dWyrmBr5Prr4QEet183pJQXuHn66a+3FYXuLey8PrnRa OqSZdsKosaGEMAjBDcFfccPULbY1pC8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1667228183; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xy2BFdtSMQu7+3yFdGMbRqBNhoao+VbAi0A7xJCvAI8=; b=LF8kq70b6qRGkxCHkzliDvR1a97EuElZ6Cirh4QB0lzpOYsfzdYZMAVYaGxcoRazQuQykE BjDaxIOfB5UGsrDg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 44E1A13451; Mon, 31 Oct 2022 14:56:23 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id hcAPDxfiX2PuCwAAMHmgww (envelope-from ); Mon, 31 Oct 2022 14:56:23 +0000 Date: Mon, 31 Oct 2022 15:56:20 +0100 From: Petr Vorel To: Martin Doucha Message-ID: References: <20221027140954.4094-1-akumar@suse.de> <96b14089-f1bb-e634-d74b-75fe92e58efa@suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <96b14089-f1bb-e634-d74b-75fe92e58efa@suse.cz> X-Virus-Scanned: clamav-milter 0.102.4 at in-3.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH] setfsuid02: using -1 as invalid fsuid for setfsuid() X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" > On 31. 10. 22 14:50, Petr Vorel wrote: > > > No, UID16_CHECK(invalid_uid, setfsuid); is the correct test call. The test > > > is supposed to verify that trying to set invalid_uid will fail, and the only > > > way to verify that it failed is to call setfsuid(invalid_uid) again and > > > check that it returns current_uid. > > I'm somehow blind today. UID16_CHECK() in compat_tst_16.h calls > > UID_SIZE_CHECK(), which just checks the uid value. I don't see setfsuid() call, > > IMHO that's done in SETFSUID(). > It doesn't make sense to call UID16_CHECK() on a value that we'll never pass > to a 16bit syscall, does it? Ah, sure, I see current_uid is used for checking only. So what is your suggestion to fix the problem on 16-bit? Kind regards, Petr -- Mailing list info: https://lists.linux.it/listinfo/ltp