From: Petr Vorel <pvorel@suse.cz>
To: Yang Xu <xuyang2018.jy@fujitsu.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] syscalls/mount03: Add statfs f_flags member check
Date: Sat, 22 Oct 2022 00:13:51 +0200 [thread overview]
Message-ID: <Y1MZnwFidi1eZoct@pevik> (raw)
In-Reply-To: <1666091413-7732-1-git-send-email-xuyang2018.jy@fujitsu.com>
Hi Xu,
Reviewed-by: Petr Vorel <pvorel@suse.cz>
> static void run(unsigned int n)
> {
> struct tcase *tc = &tcases[n];
> + struct statfs stfs;
> tst_res(TINFO, "Testing flag %s", tc->desc);
> @@ -159,6 +160,11 @@ static void run(unsigned int n)
> if (tc->test)
> tc->test();
> + SAFE_STATFS(MNTPOINT, &stfs);
> + if (stfs.f_flags & (n == 3 ? MS_REMOUNT : tc->flag))
Wouldn't it be better to add another struct member for this check?
See patch below.
Kind regards,
Petr
> + tst_res(TPASS, "statfs() gets the correct mount flag");
> + else
> + tst_res(TFAIL, "statfs() gets the incorrect mount flag");
> cleanup();
> }
diff --git testcases/kernel/syscalls/mount/mount03.c testcases/kernel/syscalls/mount/mount03.c
index 297f89838..c4d3c110a 100644
--- testcases/kernel/syscalls/mount/mount03.c
+++ testcases/kernel/syscalls/mount/mount03.c
@@ -114,16 +114,18 @@ static void test_noatime(void)
TST_EXP_EQ_LI(st.st_atime, atime);
}
-#define FLAG_DESC(x) .flag = x, .desc = #x
+#define FLAG_DESC(x) .flag = x, .flag2 = x, .desc = #x
+#define FLAG_DESC2(x) .flag2 = x, .desc = #x
static struct tcase {
unsigned int flag;
+ unsigned int flag2;
char *desc;
void (*test)(void);
} tcases[] = {
{FLAG_DESC(MS_RDONLY), test_rdonly},
{FLAG_DESC(MS_NODEV), test_nodev},
{FLAG_DESC(MS_NOEXEC), test_noexec},
- {MS_RDONLY, "MS_REMOUNT", test_remount},
+ {MS_RDONLY, FLAG_DESC2(MS_REMOUNT), test_remount},
{FLAG_DESC(MS_NOSUID), test_nosuid},
{FLAG_DESC(MS_NOATIME), test_noatime},
};
@@ -161,7 +163,7 @@ static void run(unsigned int n)
tc->test();
SAFE_STATFS(MNTPOINT, &stfs);
- if (stfs.f_flags & (n == 3 ? MS_REMOUNT : tc->flag))
+ if (stfs.f_flags & tc->flag2)
tst_res(TPASS, "statfs() gets the correct mount flag");
else
tst_res(TFAIL, "statfs() gets the incorrect mount flag");
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-10-21 22:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 11:10 [LTP] [PATCH] syscalls/mount03: Add statfs f_flags member check Yang Xu
2022-10-21 22:13 ` Petr Vorel [this message]
2022-10-24 1:20 ` xuyang2018.jy
2022-10-24 14:49 ` Richard Palethorpe
2022-10-25 2:13 ` xuyang2018.jy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1MZnwFidi1eZoct@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
--cc=xuyang2018.jy@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox