From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2403C433FE for ; Wed, 2 Nov 2022 13:36:40 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 863C13CA80D for ; Wed, 2 Nov 2022 14:36:38 +0100 (CET) Received: from in-5.smtp.seeweb.it (in-5.smtp.seeweb.it [IPv6:2001:4b78:1:20::5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 9616A3C9528 for ; Wed, 2 Nov 2022 14:36:28 +0100 (CET) Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-5.smtp.seeweb.it (Postfix) with ESMTPS id 1A14E600680 for ; Wed, 2 Nov 2022 14:36:27 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id EABC8336C4; Wed, 2 Nov 2022 13:36:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1667396186; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ebzvt+tCMAsLFxfd2DqJ/aEbIFlIGsWZTCjDHPMsFcM=; b=bnyAuKH7rXVsfk8AgR5Tlrj1h4fLhMZfbrXtz3KGkk8m1dzUMgbOc+IHMv6lQWCEteBcBZ KGK8YqVTKYbfhMy7khIPqJY4n3gbmrs57kakTyCQ7OJhUKXXOOcdq5TRzlkhPyRAoQM/o5 vgq+gKfp5qRZ25Z2qGH/N3l0U8go+p4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1667396186; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ebzvt+tCMAsLFxfd2DqJ/aEbIFlIGsWZTCjDHPMsFcM=; b=WkFUSMuxHpNzjfvKRExqNibsnhgdWYshRSZ7ZFeFRH26LvzWgCApzUHXwO+WNtS2cBQRu/ GiIoyDrfbUs+rPBQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D2477139D3; Wed, 2 Nov 2022 13:36:26 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Sba/MVpyYmMHPQAAMHmgww (envelope-from ); Wed, 02 Nov 2022 13:36:26 +0000 Date: Wed, 2 Nov 2022 14:38:00 +0100 From: Cyril Hrubis To: Tarun Sahu Message-ID: References: <20221029071344.45447-1-tsahu@linux.ibm.com> <20221029071344.45447-2-tsahu@linux.ibm.com> <20221031192519.x2exs2pfumpxe4zj@tarunpc> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221031192519.x2exs2pfumpxe4zj@tarunpc> X-Virus-Scanned: clamav-milter 0.102.4 at in-5.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v3 1/4] Hugetlb: Add new tst_test options for hugeltb test support X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: aneesh.kumar@linux.ibm.com, ltp@lists.linux.it, geetika@linux.ibm.com, sbhat@linux.ibm.com, vaibhav@linux.ibm.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > > Is there a good reason for this, why can't we call tst_umount() for > > hugetlbfs? > > > > My reason behind this is, > tst_umount doesnt break the test, if umount fails. One of the cause > of failure can be that test left the mounted fs busy, which is not > expected. This does not matter, because the do_cleanup() is called only once at the end of the test. The test exists once the function does finish anyways. -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp