From: Cyril Hrubis <chrubis@suse.cz>
To: Tarun Sahu <tsahu@linux.ibm.com>
Cc: sbhat@linux.ibm.com, aneesh.kumar@linux.ibm.com,
geetika@linux.ibm.com, vaibhav@linux.ibm.com,
rpalethorpe@suse.com, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v6 2/4] Hugetlb: Migrating libhugetlbfs brk_near_huge
Date: Thu, 3 Nov 2022 10:55:26 +0100 [thread overview]
Message-ID: <Y2OQDryqaU8bu5N4@rei> (raw)
In-Reply-To: <20221103054317.499221-3-tsahu@linux.ibm.com>
Hi!
> diff --git a/testcases/kernel/mem/hugetlb/hugemmap/Makefile b/testcases/kernel/mem/hugetlb/hugemmap/Makefile
> index 2d651b4aa..0199f8446 100644
> --- a/testcases/kernel/mem/hugetlb/hugemmap/Makefile
> +++ b/testcases/kernel/mem/hugetlb/hugemmap/Makefile
> @@ -9,3 +9,9 @@ include $(abs_srcdir)/../Makefile.inc
> include $(top_srcdir)/include/mk/generic_leaf_target.mk
>
> hugemmap06: CFLAGS+=-pthread
> +
> +ARCH ?= $(shell uname -m | sed -e s/i.86/i386/)
This will break cross-compilation. We cannot assume anything during
compilation based on the system we compile LTP on.
What are we trying to detect here?
Looking at:
https://github.com/libhugetlbfs/libhugetlbfs/commit/cc0717ca0deee9dc0bb84acc8c80fd468b180f6f
it seems that we are looking for native 32bit PPC, that means that we
have to check on runtime, because we don't know if we are going to run
in 32bit compat mode or on native 32bit machine when we are compiling.
We do have tst_kernel_bits() function exactly for this purpose.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-11-03 9:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-03 5:43 [LTP] [PATCH v6 0/4] Hugetlb:Migrating the libhugetlbfs tests Tarun Sahu
2022-11-03 5:43 ` [LTP] [PATCH v6 1/4] Hugetlb: Add new tst_test options for hugeltb test support Tarun Sahu
2022-11-03 6:08 ` Li Wang
2022-11-03 9:31 ` Tarun Sahu
2022-11-03 9:55 ` Li Wang
2022-11-03 9:45 ` Cyril Hrubis
2022-11-03 5:43 ` [LTP] [PATCH v6 2/4] Hugetlb: Migrating libhugetlbfs brk_near_huge Tarun Sahu
2022-11-03 9:55 ` Cyril Hrubis [this message]
2022-11-03 10:01 ` Cyril Hrubis
2022-11-03 5:43 ` [LTP] [PATCH v6 3/4] Hugetlb: Migrating libhugetlbfs chunk-overcommit Tarun Sahu
2022-11-03 5:43 ` [LTP] [PATCH v6 4/4] Hugetlb: Migrating libhugetlbfs corrupt-by-cow-opt Tarun Sahu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2OQDryqaU8bu5N4@rei \
--to=chrubis@suse.cz \
--cc=aneesh.kumar@linux.ibm.com \
--cc=geetika@linux.ibm.com \
--cc=ltp@lists.linux.it \
--cc=rpalethorpe@suse.com \
--cc=sbhat@linux.ibm.com \
--cc=tsahu@linux.ibm.com \
--cc=vaibhav@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox