From: Cyril Hrubis <chrubis@suse.cz>
To: Martin Doucha <mdoucha@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v3] save_restore: Introduce new struct field for flags
Date: Mon, 14 Nov 2022 16:28:09 +0100 [thread overview]
Message-ID: <Y3JeiXgTqAJbzBtB@yuki> (raw)
In-Reply-To: <7d899a16-7b4b-3ee9-8cba-949274610077@suse.cz>
Hi!
> > Would you consider adding TST_SR_TCONF_MISSING and TST_SR_TCONF_RO?
>
> I could set both to 0, if that's OK.
I suppose that would work fine.
> >> +* 'TST_SR_FAIL_MISSING' – End test with 'TBROK' if the file does not exist
> >
> > This FAIL part in this name is quite misleading since the test ends with
> > TBROK. I would say that it would be much more clear if it was named
> > TST_SR_TBROK_MISSING.
>
> Then I should also rename TST_SR_REQUIRED to TST_SR_TBROK, rename
> TST_SR_COND_ACCESS to TST_SR_SKIP and add TST_SR_TCONF for the two new
> flags.
That sounds good to me, it's much closely mapped to the actual test
result types and should be clear enough.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-11-14 15:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-14 9:32 [LTP] [PATCH v3] save_restore: Introduce new struct field for flags Martin Doucha
2022-11-14 13:25 ` Cyril Hrubis
2022-11-14 15:21 ` Martin Doucha
2022-11-14 15:28 ` Cyril Hrubis [this message]
2022-11-15 11:03 ` Richard Palethorpe
2022-11-15 10:30 ` Richard Palethorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3JeiXgTqAJbzBtB@yuki \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=mdoucha@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox