From: Petr Vorel <pvorel@suse.cz>
To: Richard Palethorpe <rpalethorpe@suse.de>
Cc: ltp@lists.linux.it, Jan Kara <jack@suse.com>
Subject: Re: [LTP] [PATCH] config: Explicitly set gnu99
Date: Tue, 22 Nov 2022 10:30:26 +0100 [thread overview]
Message-ID: <Y3yWsgwJrcsi26Vu@pevik> (raw)
In-Reply-To: <87ilj7fjz6.fsf@suse.de>
Hi Richie, Cyril,
...
> >> > I woder if this would work with different compilers. I suppose clang
> >> > does work, but what about icc?
> >> Clang is fine. I doubt that icc compiles LTP at present unless it does
> >> support GNU extensions.
> > Fair enough.
> >> > I supose that we get tons of 'can't do pointer arithmetics on void*
> >> > pointers and stuff' with plain c99. Maybe it would be better to clean
> >> > these out instead.
FYI gnu99 works on our CI
https://github.com/pevik/ltp/actions/runs/3521626082
and c99 not
https://github.com/pevik/ltp/actions/runs/3521624383
parse_opts.c:458:35: error: implicit declaration of function 'sbrk' [-Werror=implicit-function-declaration]
parse_opts.c:475:27: error: 'CLOCK_MONOTONIC' undeclared (first use in this function)
parse_opts.c:208:47: error: 'optarg' undeclared (first use in this function)
and many other errors
Richie probably found that himself.
So that I'm for merging this and Jan's fixes on the top of it.
I suppose there is no feature dependency on autotools (i.e. we don't need to add
-std=gnu99 to any of macros in m4/.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-11-22 9:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 14:45 [LTP] [PATCH] config: Explicitly set gnu99 Richard Palethorpe via ltp
2022-11-21 15:09 ` Cyril Hrubis
2022-11-21 15:14 ` Richard Palethorpe
2022-11-21 16:17 ` Cyril Hrubis
2022-11-22 8:11 ` Richard Palethorpe
2022-11-22 9:30 ` Petr Vorel [this message]
2022-11-22 10:00 ` Richard Palethorpe
2022-11-22 8:26 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3yWsgwJrcsi26Vu@pevik \
--to=pvorel@suse.cz \
--cc=jack@suse.com \
--cc=ltp@lists.linux.it \
--cc=rpalethorpe@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox