Re: [LTP] [PATCH v1] Add runltp-ng to upstream

[Petr Vorel <pvorel@suse.cz>]

Hi Andrea,

> Hi Petr,

> On 12/2/22 15:01, Petr Vorel wrote:
> > Hi Andrea,

> > > runltp-ng is the next generation runner for Linux Testing Project and it
> > > will replace the current obsolete runltp script in the next future.
> > > Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.com>
> > > ---
> > >   .gitmodules     | 3 +++
> > >   tools/runltp-ng | 1 +
> > >   2 files changed, 4 insertions(+)
> > >   create mode 160000 tools/runltp-ng
> > > diff --git a/.gitmodules b/.gitmodules
> > > index a3c34af4b..e85fc6279 100644
> > > --- a/.gitmodules
> > > +++ b/.gitmodules
> > > @@ -4,3 +4,6 @@
> > >   [submodule "tools/sparse/sparse-src"]
> > >   	path = tools/sparse/sparse-src
> > >   	url = git://git.kernel.org/pub/scm/devel/sparse/sparse.git
> > > +[submodule "tools/runltp-ng"]
> > > +	path = tools/runltp-ng
> > > +	url = https://github.com/acerv/runltp-ng
> > > diff --git a/tools/runltp-ng b/tools/runltp-ng
> > > new file mode 160000
> > > index 000000000..b08471158
> > > --- /dev/null
> > > +++ b/tools/runltp-ng
> > > @@ -0,0 +1 @@
> > > +Subproject commit b0847115891bd3dddbe920a716342917e7088379
> > Thank you for this submission! Finally we get close to adding runltp-ng :).

> > I've tested runltp-ng separately last few weeks, next week I'll do more testing
> > of b0847115891bd3dddbe920a716342917e7088379. BTW there are 2 more commits in
> > your master.

> > The integration: What I can see now is that it requires to run "git submodule
> > update --init" by user. Looking at tools/sparse/Makefile. sparse is specific
> > (not needed unless make check is evoked), therefore sparse is not installed if
> > not needed (make in tools/ does not init the submodule).

> > Maybe we could add in tools/Makefile add:
> > git submodule update --init runltp-ng/
> > That would update only runltp-ng submodule.

> Yes, submodules are not intuitive and it would be better to add code inside
> the LTP upstream.

> > I suppose there is a reason to deliver the tool separately (without LTP),
> > e.g. separate development or used on systems, which use LTP built into distro
> > package (we already use it in SUSE this way). In that case I'd be for moving the
> > repo to LTP github (https://github.com/linux-test-project/runltp-ng).

> > We could also add it directly to LTP git repository (no submodule), because also
> > for the above case (packaging) is a simple solution using just single
> > repository: there could be two separated packages: ltp and runltp-ng.

> > Otherwise to be part of LTP git repository
> > add code directly to tools/runltp-ng/.
> As far as I know, community wanted runltp-ng to be part of LTP, but at this
> stage it's probably too early (?).

IMHO it's already mature enough. I'm not sure if there is any important enough
runltp feature which it miss, but your code is obviously huge improvement over
legacy runltp.  Also you fixes various things I reported really quickly, thus I
expect you fixes any major issue in reasonable time.

Kind regards,
Petr

> > Kind regards,
> > Petr

> Andrea

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp