From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 73B73C352A1 for ; Tue, 6 Dec 2022 13:33:27 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 3EB333CC194 for ; Tue, 6 Dec 2022 14:33:24 +0100 (CET) Received: from in-4.smtp.seeweb.it (in-4.smtp.seeweb.it [IPv6:2001:4b78:1:20::4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 9C3D23C62EC for ; Tue, 6 Dec 2022 14:33:14 +0100 (CET) Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-4.smtp.seeweb.it (Postfix) with ESMTPS id C4C2E10018AA for ; Tue, 6 Dec 2022 14:33:13 +0100 (CET) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 9D59B21C4D; Tue, 6 Dec 2022 13:33:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1670333591; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nesuv8pft0da6CQIb/sSGbIUL9k7MWRawPXdOVEUFzk=; b=bv32XDj64W25QhF5JbLRQq4e1nncZIgSn5gt4TPcP3YPner9KAP2MexvFdDCg6NRkNhsPp guIR8nQ23b3QitdpeVnZ24rRNCsfkErO4O93MmJ8ioGI/rf5IoaA9YMs26zU8W3OIsy4gz rtpL5MckFSHjfALUdo1vAW1bV1EoyyI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1670333591; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nesuv8pft0da6CQIb/sSGbIUL9k7MWRawPXdOVEUFzk=; b=ZWsU+SLvuirZiBZU0/IFU7R5cP7nfMEq3oO3BzKM06ZULGqwxAXjTjoirUHamp2jYDG0W6 3mmfmSITo6U/5rBg== Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 886F213326; Tue, 6 Dec 2022 13:33:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id MYDlHpdEj2NtBgAAGKfGzw (envelope-from ); Tue, 06 Dec 2022 13:33:11 +0000 Date: Tue, 6 Dec 2022 14:33:02 +0100 From: Cyril Hrubis To: Richard Palethorpe Message-ID: References: <20221206115329.17760-1-rpalethorpe@suse.com> <20221206115329.17760-2-rpalethorpe@suse.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221206115329.17760-2-rpalethorpe@suse.com> X-Virus-Scanned: clamav-milter 0.102.4 at in-4.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH 2/2] fill_fs: Ensure written data is not easily compressed X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > --- a/lib/tst_fill_fs.c > +++ b/lib/tst_fill_fs.c > @@ -16,13 +16,20 @@ void tst_fill_fs(const char *path, int verbose) > { > int i = 0; > char file[PATH_MAX]; > - char buf[4096]; > + static char buf[4096]; I'm not sure if caching the random data is worth here, I bet that reading the random data would be neglectible to the rest of the write operations we do. -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp