From: Petr Vorel <pvorel@suse.cz>
To: Martin Doucha <mdoucha@suse.cz>
Cc: ltp@lists.linux.it, David Hildenbrand <david@redhat.com>
Subject: Re: [LTP] [PATCH v2] security/dirtyc0w_shmem: Add new test for CVE-2022-2590
Date: Fri, 25 Nov 2022 11:39:17 +0100 [thread overview]
Message-ID: <Y4CbVZ3MKmjG9x96@pevik> (raw)
In-Reply-To: <30abc28c-be3c-0f9e-0c2e-6614fdd30e0c@suse.cz>
Hi Martin, David,
> On 23. 11. 22 11:35, David Hildenbrand wrote:
> > + uffdio_api.api = UFFD_API;
> > + uffdio_api.features = UFFD_FEATURE_MINOR_SHMEM;
> > + TEST(ioctl(uffd, UFFDIO_API, &uffdio_api));
> > + if (TST_RET < 0) {
> One more thing, checking just the ioctl() return value here is not enough.
> You need to check that uffdio_api.features still includes the
> UFFD_FEATURE_MINOR_SHMEM flag after the call. PPC64 does not seem to support
> it on kernel 5.14 and the ioctl() still succeeds there.
Very good catch, thanks!
David, please send official patch (speedups merging). Thanks a lot!
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-11-25 10:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-23 10:35 [LTP] [PATCH v2] security/dirtyc0w_shmem: Add new test for CVE-2022-2590 David Hildenbrand
2022-11-24 22:13 ` Petr Vorel
2022-11-25 9:53 ` Martin Doucha
2022-11-25 10:06 ` Petr Vorel
2022-11-25 10:20 ` David Hildenbrand
2022-11-25 10:25 ` Martin Doucha
2022-11-25 10:29 ` David Hildenbrand
2022-11-25 10:39 ` Petr Vorel
2022-11-25 10:42 ` David Hildenbrand
2022-11-25 10:17 ` David Hildenbrand
2022-11-25 14:22 ` Cyril Hrubis
2022-11-25 14:26 ` Martin Doucha
2022-11-25 14:35 ` Cyril Hrubis
2022-11-25 10:37 ` Martin Doucha
2022-11-25 10:39 ` Petr Vorel [this message]
2022-11-25 10:40 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4CbVZ3MKmjG9x96@pevik \
--to=pvorel@suse.cz \
--cc=david@redhat.com \
--cc=ltp@lists.linux.it \
--cc=mdoucha@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox