public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: David Hildenbrand <david@redhat.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v1 0/3] userfaultfd: Fix and remove compile-time TCONF handling
Date: Mon, 28 Nov 2022 12:57:01 +0100	[thread overview]
Message-ID: <Y4SiDZXCSqMafjIb@pevik> (raw)
In-Reply-To: <20221128111833.98937-1-david@redhat.com>

Hi David,

If I remember correctly the reason for runtime check was ppc64le
missing userfaultfd minor fault support which needs to be check in runtime,
right? [1]. At least this is how I understand Martin's suggestion [2] to replace
compile time check with lapi. I'd state this reason at first commit message as
it's not obvious.

Otherwise whole patchset LGTM.

Kind regards,
Petr

[1] https://lore.kernel.org/ltp/30abc28c-be3c-0f9e-0c2e-6614fdd30e0c@suse.cz/
[2] https://lore.kernel.org/ltp/6ce3a102-f2ec-16be-927d-a32ab46eaf0c@suse.cz/

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  parent reply	other threads:[~2022-11-28 11:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-28 11:18 [LTP] [PATCH v1 0/3] userfaultfd: Fix and remove compile-time TCONF handling David Hildenbrand
2022-11-28 11:18 ` [LTP] [PATCH v1 1/3] lapi/userfaultfd.h: Preparation for removing compile-time TCONF handling from userfaultfd testcases David Hildenbrand
2022-11-28 11:18 ` [LTP] [PATCH v1 2/3] security/dirtyc0w_shmem: Fix compile-time absence of UFFD_FEATURE_MINOR_SHMEM David Hildenbrand
2022-11-28 11:18 ` [LTP] [PATCH v1 3/3] syscalls/userfaultfd01: Remove compile-time TCONF handling David Hildenbrand
2022-11-28 11:57 ` Petr Vorel [this message]
2022-11-28 12:29   ` [LTP] [PATCH v1 0/3] userfaultfd: Fix and remove " Martin Doucha
2022-11-28 15:44     ` David Hildenbrand
2022-11-28 18:42       ` Petr Vorel
2022-11-29  8:29         ` Petr Vorel
2022-11-29  8:46           ` David Hildenbrand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y4SiDZXCSqMafjIb@pevik \
    --to=pvorel@suse.cz \
    --cc=david@redhat.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox