Re: [LTP] [PATCH] mkfs: relax size check

[Petr Vorel <pvorel@suse.cz>]

Hi zenghongling,

> Number of total data blocks in filesystem reported by statfs
> may be less than current formula of 90%. For example ext4 will
> subtract "s_first_data_block plus internal journal blocks".

> With recent change to e2fsprogs, overhead calculated in user-space increased
Do you know in which version it got changed?
Maybe it'd be worth to mention that to ext4 maintainers,
just to be sure it's not a regression.

> slightly and LTP test started failing: tytso/e2fsprogs
A bit cryptic description :(. You mean probably https://github.com/tytso/e2fsprogs
which is also on
https://git.kernel.org/pub/scm/fs/ext2/e2fsprogs.git/

Kind regards,
Petr

> mkfs01 1 TPASS: 'mkfs -t ext4  /dev/loop0 ' passed.
> mkfs01 2 TFAIL: 'mkfs -t ext4  /dev/loop0 16000' failed, not expected.

> Since there's no strict rule how much the overhead will be,
> as rule of thumb relax the condition to 70%.

> Signed-off-by: zenghongling <zenghongling@kylinos.cn>
> ---
>  testcases/commands/mkfs/mkfs01.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

> diff --git a/testcases/commands/mkfs/mkfs01.sh b/testcases/commands/mkfs/mkfs01.sh
> index 263aa47..a964774 100755
> --- a/testcases/commands/mkfs/mkfs01.sh
> +++ b/testcases/commands/mkfs/mkfs01.sh
> @@ -66,11 +66,11 @@ mkfs_verify_size()
>  	# 1k-block size should be devided by this argument for ntfs verification.
>  	if [ "$1" = "ntfs" ]; then
>  		local rate=1024/512
> -		if [ $blocknum -lt "$(($2/$rate*8/10))" ]; then
> +		if [ $blocknum -lt "$(($2/$rate*7/10))" ]; then
>  			return 1
>  		fi
>  	else
> -		if [ $blocknum -lt "$(($2*8/10))" ]; then
> +		if [ $blocknum -lt "$(($2*7/10))" ]; then
>  			return 1
>  		fi
>  	fi

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp