From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1DCCDC4321E for ; Wed, 30 Nov 2022 08:52:37 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id B65FC3CC4FD for ; Wed, 30 Nov 2022 09:52:34 +0100 (CET) Received: from in-6.smtp.seeweb.it (in-6.smtp.seeweb.it [IPv6:2001:4b78:1:20::6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 759E03C9008 for ; Wed, 30 Nov 2022 09:52:24 +0100 (CET) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-6.smtp.seeweb.it (Postfix) with ESMTPS id E6CF41400DA3 for ; Wed, 30 Nov 2022 09:52:23 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id DB2CB21AF3; Wed, 30 Nov 2022 08:52:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1669798342; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=q1KQuT+myEteW8+g7H/RbNFju0Sq6iJMoQwm1W21b1U=; b=ngm3ZjzqCOed2Tu96GlsJd6/UsRMUtT/enm/Sd3dquZyVWuVR18pBpWGITkIfUDkfQ3bfY ksfF5nhtb5FA1g6ySBnLsCtqlNor44VuK9nUnCJP+9qRlxta2e1SOyHzoepQU22vlmtiPL 04+eqXSNZ9W6wvW3MRXPk2Pc6jjmEvo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1669798342; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=q1KQuT+myEteW8+g7H/RbNFju0Sq6iJMoQwm1W21b1U=; b=Oq8cz98eDWY6W5Ki7EnZxoeiqw2zuS6lXiLzVuAMzxVMKm9qpLVkFSquTflsG33bDyilmE xw2UjzqmDK1aYaCw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 921051331F; Wed, 30 Nov 2022 08:52:22 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id EpvXIMYZh2MTTgAAMHmgww (envelope-from ); Wed, 30 Nov 2022 08:52:22 +0000 Date: Wed, 30 Nov 2022 09:52:20 +0100 From: Petr Vorel To: Avinesh Kumar Message-ID: References: <87r0xmt3ts.fsf@suse.de> <20221130070500.28664-1-akumar@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221130070500.28664-1-akumar@suse.de> X-Virus-Scanned: clamav-milter 0.102.4 at in-6.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v2] statvfs01: Convert to new LTP API X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: Richard Palethorpe , ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi Avinesh, > Removed the TINFO statements, > Added a validation of statvfs.f_namemax field by trying to create > files of valid and invalid length names. Very nice rewrite, thanks for adding this veryfication. It'd be nice to update this in docparse description. > + > +/*\ > + * [Description] > + * > + * Verify that statvfs() executes successfully for all > + * available filesystems. e.g.: Verify that statvfs() executes successfully for all available filesystems. Verify statvfs.f_namemax field by trying to create files of valid and invalid length names. I can merge it with this change. Reviewed-by: Petr Vorel ... > +static struct tst_test test = { > + .test_all = run, > + .setup = setup, > + .needs_root = 1, > + .mount_device = 1, > + .mntpoint = MNT_POINT, > + .all_filesystems = 1, > + .skip_filesystems = (const char *const[]) { > + "vfat", > + "exfat", I was looking what's wrong with vfat and exfat. statvfs.f_namemax returns 1530, which is obviously too long, thus valid_fname obviously returns ENAMETOOLONG (36). Tested on 6.1.0-rc6-1.g4c01546-default. I wonder why, isn't that a bug? Kind regards, Petr -- Mailing list info: https://lists.linux.it/listinfo/ltp