From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8D5ADC352A1 for ; Wed, 30 Nov 2022 14:06:48 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 77E823CC543 for ; Wed, 30 Nov 2022 15:06:46 +0100 (CET) Received: from in-6.smtp.seeweb.it (in-6.smtp.seeweb.it [217.194.8.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 19DA23C0367 for ; Wed, 30 Nov 2022 15:06:35 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-6.smtp.seeweb.it (Postfix) with ESMTPS id 8B0EC1400B87 for ; Wed, 30 Nov 2022 15:06:35 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id DD2551F37C; Wed, 30 Nov 2022 14:06:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1669817194; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qx68NTpY6ClwM2XbilRROkLlOYVeAp+ngIyGL3wSjO0=; b=fm8Hhl7OA3sO6MDvaqR+UjXpyDGQ0aWM3UBgFwQogJg8BtHFCvCALjXcrZ8tMxAdUfbXnO ozQOAYj+n/w2YtQOkqjDbZ3uaiCNdlWKEGpyhjWQLomlNO3SvbSZFBjTOfkDO3nfSOv2Mp AexaT180X+G4z4Wkiyf9DYsHXgf8+0s= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1669817194; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qx68NTpY6ClwM2XbilRROkLlOYVeAp+ngIyGL3wSjO0=; b=/N5NdvHKudb+aJcBX3Sa+ZfBrfsWmUIRDCEOODhD8YxqjIfa9Ns4Qn3Qrm8+KQ+/32LmeZ bPLRmrNztiyphoDA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C197113A70; Wed, 30 Nov 2022 14:06:34 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Rz8dLWpjh2OfcwAAMHmgww (envelope-from ); Wed, 30 Nov 2022 14:06:34 +0000 Date: Wed, 30 Nov 2022 15:06:29 +0100 From: Cyril Hrubis To: Tudor Cretu Message-ID: References: <20221130133619.632073-1-tudor.cretu@arm.com> <20221130133619.632073-3-tudor.cretu@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221130133619.632073-3-tudor.cretu@arm.com> X-Virus-Scanned: clamav-milter 0.102.4 at in-6.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v3 2/3] safe_open, safe_openat: Fix undefined behaviour in vararg handling X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > +#ifndef __OPEN_NEEDS_MODE > + #define __OPEN_NEEDS_MODE(oflag) \ > + (((oflag) & O_CREAT) != 0 || ((oflag) & O_TMPFILE) == O_TMPFILE) > +#endif I suppose that it would be a bit cleaner just to define our macro TST_OPEN_NEEDS_MODE() instead. Other than that it looks good. -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp